Bug 106803

Summary: [Chromium] Move AudioDestinationChromium into WebCore
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: WebKit Misc.Assignee: Mark Pilgrim (Google) <pilgrim>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric.carlson, feature-media-reviews, fishd, haraken, jamesr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 106829    
Attachments:
Description Flags
Patch
none
Patch none

Mark Pilgrim (Google)
Reported 2013-01-14 09:51:14 PST
[Chromium] Move AudioDestinationChromium into WebCore
Attachments
Patch (23.32 KB, patch)
2013-01-14 09:52 PST, Mark Pilgrim (Google)
no flags
Patch (23.27 KB, patch)
2013-01-14 12:28 PST, Mark Pilgrim (Google)
no flags
Mark Pilgrim (Google)
Comment 1 2013-01-14 09:52:51 PST
Adam Barth
Comment 2 2013-01-14 10:12:59 PST
Comment on attachment 182594 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182594&action=review > Source/WebCore/platform/audio/chromium/AudioDestinationChromium.cpp:31 > +#if ENABLE(WEB_AUDIO) We usually put a blank line after this line. > Source/WebCore/platform/audio/chromium/AudioDestinationChromium.cpp:38 > +using namespace WebKit; Can we skip this using directive? In WebCore, it's nice to be able to see what's used from the API. > Source/WebCore/platform/audio/chromium/AudioDestinationChromium.cpp:45 > +// Size of the FIFO There are lots of style errors in this file, but I guess I won't point them out since you're just moving this code. > Source/WebCore/platform/audio/chromium/AudioDestinationChromium.h:39 > +namespace WebKit { class WebAudioDevice; } You probably don't need to forward declare this class given that you #include public/WebAudioDevice.h
Mark Pilgrim (Google)
Comment 3 2013-01-14 12:28:35 PST
Mark Pilgrim (Google)
Comment 4 2013-01-14 12:29:08 PST
Comment on attachment 182610 [details] Patch Nits addressed.
WebKit Review Bot
Comment 5 2013-01-14 13:23:04 PST
Comment on attachment 182610 [details] Patch Clearing flags on attachment: 182610 Committed r139652: <http://trac.webkit.org/changeset/139652>
WebKit Review Bot
Comment 6 2013-01-14 13:23:08 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.