Bug 106801

Summary:

Web Inspector: highlight regexp API for DefaultTextEditor

Product:

WebKit

Reporter:

Andrey Lushnikov <lushnikov>

Component:

Web Inspector (Deprecated)

Assignee:

Andrey Lushnikov <lushnikov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, buildbot, dglazkov, keishi, loislo, pfeldman, pmuellr, rniwa, vsevik, web-inspector-bugs, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Andrey Lushnikov

Reported 2013-01-14 09:32:08 PST

Add a highlight regexp API for TextEditor and DefaultTextEditor. This API should provide with the following capabilities: - highlight all occurrences of regexp in text with some css class - remove highlight for given regexp

Attachments
Patch (19.41 KB, patch) 2013-01-14 09:41 PST, Andrey Lushnikov	no flags	Details Formatted Diff Diff
Patch (19.17 KB, patch) 2013-01-14 09:46 PST, Andrey Lushnikov	no flags	Details Formatted Diff Diff
Patch (18.89 KB, patch) 2013-01-15 02:22 PST, Andrey Lushnikov	no flags	Details Formatted Diff Diff
Patch (13.98 KB, patch) 2013-01-15 06:18 PST, Andrey Lushnikov	no flags	Details Formatted Diff Diff
Patch (13.89 KB, patch) 2013-01-16 00:21 PST, Andrey Lushnikov	no flags	Details Formatted Diff Diff
Patch (13.89 KB, patch) 2013-01-16 02:42 PST, Andrey Lushnikov	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Andrey Lushnikov

Comment 1 2013-01-14 09:41:42 PST

Created attachment 182592 [details] Patch

Andrey Lushnikov

Comment 2 2013-01-14 09:46:03 PST

Created attachment 182593 [details] Patch

Pavel Feldman

Comment 3 2013-01-14 09:56:52 PST

Comment on attachment 182593 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182593&action=review Please rename Regexp into Regex in method names. > Source/WebCore/inspector/front-end/DefaultTextEditor.js:116 > + highlightRegexp: function(regexp, cssClass) highlightRegex > Source/WebCore/inspector/front-end/DefaultTextEditor.js:1961 > + offsetTop: spans[i].offsetTop, nuke > Source/WebCore/inspector/front-end/DefaultTextEditor.js:1963 > + offsetHeight: spans[i].offsetHeight nuke > Source/WebCore/inspector/front-end/DefaultTextEditor.js:1980 > + highlight.style.marginTop = (metrics[i].offsetTop - highlight.offsetTop) + "px"; nuke > Source/WebCore/inspector/front-end/DefaultTextEditor.js:2054 > + if (!this._highlightRegexps.hasOwnProperty(key)) This is always false.

Andrey Lushnikov

Comment 4 2013-01-15 02:22:50 PST

Created attachment 182725 [details] Patch

Build Bot

Comment 5 2013-01-15 03:32:17 PST

Comment on attachment 182725 [details] Patch Attachment 182725 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15845891 New failing tests: inspector/editor/highlighter-basics.html inspector/editor/text-editor-highlight-regexp.html inspector/editor/highlighter-paste-in-comment.html

WebKit Review Bot

Comment 6 2013-01-15 04:02:35 PST

Comment on attachment 182725 [details] Patch Attachment 182725 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15860912 New failing tests: inspector/editor/highlighter-basics.html inspector/editor/highlighter-paste-in-comment.html

Andrey Lushnikov

Comment 7 2013-01-15 06:18:37 PST

Created attachment 182752 [details] Patch

Pavel Feldman

Comment 8 2013-01-15 07:21:14 PST

Comment on attachment 182752 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182752&action=review > Source/WebCore/inspector/front-end/DefaultTextEditor.js:1977 > + var extraWidth = 1; const

WebKit Review Bot

Comment 9 2013-01-15 07:23:08 PST

Comment on attachment 182752 [details] Patch Rejecting attachment 182752 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: ore/inspector/front-end/TextEditor.js patching file Source/WebCore/inspector/front-end/textEditor.css patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/inspector/editor/text-editor-highlight-regexp-expected.txt patching file LayoutTests/inspector/editor/text-editor-highlight-regexp.html Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Pavel Feldman']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/15884591

Andrey Lushnikov

Comment 10 2013-01-16 00:21:24 PST

Created attachment 182927 [details] Patch

Pavel Feldman

Comment 11 2013-01-16 00:50:22 PST

Comment on attachment 182927 [details] Patch Clearing flags on attachment: 182927 Committed r139844: <http://trac.webkit.org/changeset/139844>

Pavel Feldman

Comment 12 2013-01-16 00:50:27 PST

All reviewed patches have been landed. Closing bug.

Andrey Lushnikov

Comment 13 2013-01-16 02:42:18 PST

Reopening to attach new patch.

Andrey Lushnikov

Comment 14 2013-01-16 02:42:22 PST

Created attachment 182945 [details] Patch

Andrey Lushnikov

Comment 15 2013-01-16 02:44:19 PST

Attached patch to a wrong bug.

Note You need to log in before you can comment on or make changes to this bug.