Summary: | [GTK] build-webkit fails if the jhbuild wrapper is not used | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sergio Villar Senin <svillar> | ||||||||||
Component: | WebKitGTK | Assignee: | Sergio Villar Senin <svillar> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | dbates, gtk-ews, gustavo, hausmann, kenneth, laszlo.gombos, mrobinson, ossy, svillar, xan.lopez | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Sergio Villar Senin
2013-01-14 02:03:01 PST
Created attachment 182529 [details]
Patch
I found this while trying to use WEBKITOUTPUTDIR. The jhbuild wrapper was not used because I didn't have the "Dependencies" folder in the new location specified by the environmnet variable. Comment on attachment 182529 [details] Patch Attachment 182529 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/15868440 Created attachment 182551 [details]
Patch
Created attachment 182555 [details]
Patch
Comment on attachment 182555 [details] Patch Attachment 182555 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/15868501 (In reply to comment #6) > (From update of attachment 182555 [details]) > Attachment 182555 [details] did not pass gtk-ews (gtk): > Output: http://queues.webkit.org/results/15868501 Beh, not sure where that "3" comes from... Comment on attachment 182555 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182555&action=review The build failure seems legitimate, so it should probably be fixed. > Tools/Scripts/webkitdirs.pm:1967 > + # Prefix the command with jhbuild run. > + my $jhbuildWrapper = jhbuildWrapperPrefixIfNeeded(); > + unshift(@buildArgs, $jhbuildWrapper) if ($jhbuildWrapper ne ""); > + Why not add a function like prefixWithJHBuildWrapperIfNeeded()? Created attachment 182729 [details]
Patch
Comment on attachment 182729 [details] Patch Clearing flags on attachment: 182729 Committed r139868: <http://trac.webkit.org/changeset/139868> All reviewed patches have been landed. Closing bug. |