Bug 106737 – Make ninja the default build system for build-webkit --chromium on mac

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Nico Weber]

Like bug 104434, but for chromium/mac.

[Nico Weber]

As it turns out, my attempt to make nrwt find the right binary automatically in http://trac.webkit.org/changeset/138294 wasn't quite right: it looks in Source/WebKit/chromium/xcodebuild/Release/DumpRenderTree.app/Contents/MacOS/DumpRenderTree (good) and Source/WebKit/chromium/out/Release/DumpRenderTree.app/Contents/MacOS/DumpRenderTree (bad, should look in out/Release/DumpRenderTree.app/Contents/MacOS/DumpRenderTree instead).

Since NRWT is so lasagna-code-y, it's not obvious how to fix that. I'll look at it some.

[Nico Weber]

Hey, I think my patch in bug 105597 probably addresses that. I should land it.

[Nico Weber]

Looks like this works now, at least with a standalone webkit build.

[Nico Weber]

With a standalone build, layout_tests/port/chromium.py's _static_build_path looks in these places:

/Users/thakis/src/WebKit/Source/WebKit/chromium/xcodebuild/Release/DumpRenderTree.app/Contents/MacOS/DumpRenderTree
/Users/thakis/src/WebKit/Source/WebKit/chromium/out/Release/DumpRenderTree.app/Contents/MacOS/DumpRenderTree
/Users/thakis/src/WebKit/xcodebuild/Release/DumpRenderTree.app/Contents/MacOS/DumpRenderTree
/Users/thakis/src/WebKit/out/Release/DumpRenderTree.app/Contents/MacOS/DumpRenderTree

This includes the two right locations, so things work.

In a webkit-in-chromium build, it looks in

/Users/thakis/src/chrome/src/xcodebuild/Release/DumpRenderTree.app/Contents/MacOS/DumpRenderTree
/Users/thakis/src/chrome/src/out/Release/DumpRenderTree.app/Contents/MacOS/DumpRenderTree
/Users/thakis/src/chrome/src/third_party/WebKit/xcodebuild/Release/DumpRenderTree.app/Contents/MacOS/DumpRenderTree
/Users/thakis/src/chrome/src/third_party/WebKit/out/Release/DumpRenderTree.app/Contents/MacOS/DumpRenderTree

This is _almost_ right, but it doesn't look in third_party/WebKit/Source/WebKit/chromium/xcodebuild. However, that's already the case in trunk and nobody's complaining, so I guess nobody is doing webkit-in-chromium builds _and_ builds with xcodebuild and build-webkit.

[Nico Weber]

Filed bug 106745 for the problem in comment 4.

[Nico Weber]

Created attachment 182487 [details]
Patch

[Nico Weber]

I think this should work, but let's wait with landing this until next weekend, to see if there are any problems with the ninja transition on linux.

[Eric Seidel (no email)]

Comment on attachment 182487 [details]
Patch

I wish to buy this product and or service.  I might have written this as ! win however.

[WebKit Review Bot]

Comment on attachment 182487 [details]
Patch

Clearing flags on attachment: 182487

Committed r140260: <http://trac.webkit.org/changeset/140260>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

Re-opened since this is blocked by bug 107387

[Nico Weber]

This is blocked on https://code.google.com/p/chromium/issues/detail?id=171146

[Nico Weber]

The hyphen stuff should now work. Let's try this again.

[WebKit Review Bot]

Comment on attachment 182487 [details]
Patch

Rejecting attachment 182487 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

/mnt/git/webkit-commit-queue/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/16039187

[Nico Weber]

Created attachment 183825 [details]
Patch for landing

[Nico Weber]

Comment on attachment 183825 [details]
Patch for landing

I fail at webkit-patch

[Nico Weber]

Created attachment 183827 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 183827 [details]
Patch for landing

Clearing flags on attachment: 183827

Committed r140360: <http://trac.webkit.org/changeset/140360>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.