Bug 106698

Summary: Builder should not be a valid parameter for stats dashboard
Product: WebKit Reporter: Julie Parent <jparent>
Component: Tools / TestsAssignee: Julie Parent <jparent>
Severity: Normal CC: dpranke, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch for landing none

Description Julie Parent 2013-01-11 14:01:55 PST
This dashboard displays results for all builders, so builder is not a valid parameter here, as it is for other dashboards.

Aka, loading http://test-results.appspot.com/dashboards/aggregate_results.html#builder=WebKit%20Win7 should at least print a warning about invalid parameter.
Comment 1 Julie Parent 2013-01-11 14:27:30 PST
Created attachment 182418 [details]
Comment 2 Dirk Pranke 2013-01-11 14:57:18 PST
Comment on attachment 182418 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=182418&action=review

> Tools/ChangeLog:12
> +        Note that the FIXME in dashboard_base about this was acutally wrong -

nit: "actually".
Comment 3 Julie Parent 2013-01-11 15:26:52 PST
Created attachment 182432 [details]
Patch for landing
Comment 4 WebKit Review Bot 2013-01-11 16:43:12 PST
Comment on attachment 182432 [details]
Patch for landing

Clearing flags on attachment: 182432

Committed r139522: <http://trac.webkit.org/changeset/139522>
Comment 5 WebKit Review Bot 2013-01-11 16:43:15 PST
All reviewed patches have been landed.  Closing bug.