Bug 106696

Summary: Allow nesting of at-rules
Product: WebKit Reporter: Pablo Flouret <pf>
Component: CSSAssignee: Pablo Flouret <pf>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, buildbot, cmarcelo, dglazkov, koivisto, macpherson, menard, ojan.autocc, rniwa, webkit.review.bot
Priority: P2 Keywords: WebExposed
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 104822    
Attachments:
Description Flags
Patch
none
Patch none

Description Pablo Flouret 2013-01-11 13:38:55 PST 
http://dev.w3.org/csswg/css3-conditional/#processing introduces the concept of grouping rules, and allows for them to be nested. In particular, this change affects @media (and is needed for @supports as well).
Comment 1 Pablo Flouret 2013-01-11 14:48:22 PST 
Created attachment 182420 [details]
Patch
Comment 2 Build Bot 2013-01-11 15:49:52 PST 
Comment on attachment 182420 [details]
Patch

Attachment 182420 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15830071
Comment 3 WebKit Review Bot 2013-01-11 17:01:41 PST 
Comment on attachment 182420 [details]
Patch

Attachment 182420 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15833079

New failing tests:
fast/text/international/hindi-spacing.html
Comment 4 Pablo Flouret 2013-01-11 17:28:03 PST 
Created attachment 182450 [details]
Patch
Comment 5 Allan Sandfeld Jensen 2013-01-14 01:40:54 PST 
Comment on attachment 182450 [details]
Patch

Looks good, it even cleans up code duplication.
Comment 6 WebKit Review Bot 2013-01-14 01:51:22 PST 
Comment on attachment 182450 [details]
Patch

Clearing flags on attachment: 182450

Committed r139594: <http://trac.webkit.org/changeset/139594>
Comment 7 WebKit Review Bot 2013-01-14 01:51:26 PST 
All reviewed patches have been landed.  Closing bug.