Bug 106696

Summary: Allow nesting of at-rules
Product: WebKit Reporter: Pablo Flouret <pf>
Component: CSSAssignee: Pablo Flouret <pf>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, buildbot, cmarcelo, dglazkov, koivisto, macpherson, menard, ojan.autocc, rniwa, webkit.review.bot
Priority: P2 Keywords: WebExposed
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 104822    
Attachments:
Description Flags
Patch
none
Patch none

Pablo Flouret
Reported 2013-01-11 13:38:55 PST
http://dev.w3.org/csswg/css3-conditional/#processing introduces the concept of grouping rules, and allows for them to be nested. In particular, this change affects @media (and is needed for @supports as well).
Attachments
Patch (13.51 KB, patch)
2013-01-11 14:48 PST, Pablo Flouret 		no flags
DetailsFormatted DiffDiff
Patch (14.02 KB, patch)
2013-01-11 17:28 PST, Pablo Flouret 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pablo Flouret
Comment 1 2013-01-11 14:48:22 PST
Created attachment 182420 [details] Patch
Build Bot
Comment 2 2013-01-11 15:49:52 PST
Comment on attachment 182420 [details] Patch Attachment 182420 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15830071
WebKit Review Bot
Comment 3 2013-01-11 17:01:41 PST
Comment on attachment 182420 [details] Patch Attachment 182420 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15833079 New failing tests: fast/text/international/hindi-spacing.html
Pablo Flouret
Comment 4 2013-01-11 17:28:03 PST
Created attachment 182450 [details] Patch
Allan Sandfeld Jensen
Comment 5 2013-01-14 01:40:54 PST
Comment on attachment 182450 [details] Patch Looks good, it even cleans up code duplication.
WebKit Review Bot
Comment 6 2013-01-14 01:51:22 PST
Comment on attachment 182450 [details] Patch Clearing flags on attachment: 182450 Committed r139594: <http://trac.webkit.org/changeset/139594>
WebKit Review Bot
Comment 7 2013-01-14 01:51:26 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.