Bug 106694

Summary: Move constructTreeFromHTMLToken into HTMLDocumentParser
Product: WebKit Reporter: Tony Gentilcore <tonyg>
Component: New BugsAssignee: Tony Gentilcore <tonyg>
Status: RESOLVED FIXED    
Severity: Normal CC: ojan.autocc, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 106127    
Attachments:
Description Flags
Patch
none
Patch none

Description Tony Gentilcore 2013-01-11 13:20:54 PST 
Move constructTreeFromHTMLToken into HTMLDocumentParser
Comment 1 Tony Gentilcore 2013-01-11 13:21:41 PST 
Created attachment 182403 [details]
Patch
Comment 2 Adam Barth 2013-01-11 13:26:42 PST 
Comment on attachment 182403 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182403&action=review

> Source/WebCore/html/parser/HTMLTreeBuilder.h:81
>      void constructTreeFromAtomicToken(AtomicHTMLToken*);

I would probably rename this function to "constructTree" now that we only have one.  :)
Comment 3 Tony Gentilcore 2013-01-11 13:34:41 PST 
Created attachment 182408 [details]
Patch
Comment 4 Tony Gentilcore 2013-01-11 13:35:17 PST 
(In reply to comment #2)
> (From update of attachment 182403 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=182403&action=review
> 
> > Source/WebCore/html/parser/HTMLTreeBuilder.h:81
> >      void constructTreeFromAtomicToken(AtomicHTMLToken*);
> 
> I would probably rename this function to "constructTree" now that we only have one.  :)

Good catch. Done.
Comment 5 WebKit Review Bot 2013-01-11 17:30:04 PST 
Comment on attachment 182408 [details]
Patch

Clearing flags on attachment: 182408

Committed r139523: <http://trac.webkit.org/changeset/139523>
Comment 6 WebKit Review Bot 2013-01-11 17:30:08 PST 
All reviewed patches have been landed.  Closing bug.