Bug 106694

Summary: Move constructTreeFromHTMLToken into HTMLDocumentParser
Product: WebKit Reporter: Tony Gentilcore <tonyg>
Component: New BugsAssignee: Tony Gentilcore <tonyg>
Status: RESOLVED FIXED    
Severity: Normal CC: ojan.autocc, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 106127    
Attachments:
Description Flags
Patch
none
Patch none

Tony Gentilcore
Reported 2013-01-11 13:20:54 PST
Move constructTreeFromHTMLToken into HTMLDocumentParser
Attachments
Patch (6.35 KB, patch)
2013-01-11 13:21 PST, Tony Gentilcore 		no flags
DetailsFormatted DiffDiff
Patch (7.47 KB, patch)
2013-01-11 13:34 PST, Tony Gentilcore 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tony Gentilcore
Comment 1 2013-01-11 13:21:41 PST
Created attachment 182403 [details] Patch
Adam Barth
Comment 2 2013-01-11 13:26:42 PST
Comment on attachment 182403 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182403&action=review > Source/WebCore/html/parser/HTMLTreeBuilder.h:81 > void constructTreeFromAtomicToken(AtomicHTMLToken*); I would probably rename this function to "constructTree" now that we only have one. :)
Tony Gentilcore
Comment 3 2013-01-11 13:34:41 PST
Created attachment 182408 [details] Patch
Tony Gentilcore
Comment 4 2013-01-11 13:35:17 PST
(In reply to comment #2) > (From update of attachment 182403 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=182403&action=review > > > Source/WebCore/html/parser/HTMLTreeBuilder.h:81 > > void constructTreeFromAtomicToken(AtomicHTMLToken*); > > I would probably rename this function to "constructTree" now that we only have one. :) Good catch. Done.
WebKit Review Bot
Comment 5 2013-01-11 17:30:04 PST
Comment on attachment 182408 [details] Patch Clearing flags on attachment: 182408 Committed r139523: <http://trac.webkit.org/changeset/139523>
WebKit Review Bot
Comment 6 2013-01-11 17:30:08 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.