Summary: | Web Inspector: [Canvas] introduce CallArgument type into the protocol | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andrey Adaikin <aandrey> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Andrey Adaikin <aandrey> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | apavlov, buildbot, keishi, loislo, pfeldman, pmuellr, rniwa, vsevik, web-inspector-bugs, webkit.review.bot, yurys | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Andrey Adaikin
2013-01-11 00:59:24 PST
Created attachment 182287 [details]
Patch
Comment on attachment 182287 [details] Patch Attachment 182287 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15809246 New failing tests: inspector/profiler/webgl/webgl-profiler-get-error.html Created attachment 182311 [details]
Patch
Comment on attachment 182311 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182311&action=review The patch mixes several unrelated changes which can be done in a separate CLs and would simplify the review process. > Source/WebCore/inspector/Inspector.json:3210 > + { "name": "arguments", "type": "array", "items": { "$ref": "CallArgument" }, "optional": true }, Would be nice to have descriptions for the properties. (In reply to comment #4) > (From update of attachment 182311 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=182311&action=review > > The patch mixes several unrelated changes which can be done in a separate CLs and would simplify the review process. > > > Source/WebCore/inspector/Inspector.json:3210 > > + { "name": "arguments", "type": "array", "items": { "$ref": "CallArgument" }, "optional": true }, > > Would be nice to have descriptions for the properties. Yeah, I intentionally kept this whole protocol hidden and undocumented while it's in a development state. I'd rather leave this as is and focus on other stuff for now, but if you insist, I'll add documentation in separate patch. Comment on attachment 182311 [details] Patch Clearing flags on attachment: 182311 Committed r139729: <http://trac.webkit.org/changeset/139729> All reviewed patches have been landed. Closing bug. |