Bug 106630

Summary: Blur the label background of a snapshotted plugin
Product: WebKit Reporter: Dean Jackson <dino>
Component: Plug-insAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, jonlee, ojan.autocc, simon.fraser, thorton, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP Patch
none
Patch simon.fraser: review+

Dean Jackson
Reported 2013-01-10 20:15:28 PST
Provide the ability to blur the snapshot of the plugin behind any label we want to display. This would allow a transparent label that is more readable.
Attachments
WIP Patch (5.07 KB, patch)
2013-01-10 20:26 PST, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Patch (12.17 KB, patch)
2013-01-14 16:27 PST, Dean Jackson 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-01-10 20:16:01 PST
<rdar://problem/12994916>
Dean Jackson
Comment 2 2013-01-10 20:26:54 PST
Created attachment 182250 [details] WIP Patch
Dean Jackson
Comment 3 2013-01-14 16:27:50 PST
Created attachment 182655 [details] Patch
Simon Fraser (smfr)
Comment 4 2013-01-14 16:50:34 PST
Comment on attachment 182655 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182655&action=review > Source/WebCore/ChangeLog:13 > + slightly blur the snapshot behind the label so that it is more clear. All the code > + here is platform-neutral, but the treatment is specific to Mac. Unfortunately I > + couldn't find a better place to put the code (RenderThemeMac depends on a bunch > + of Objective C classes). The good news is that this operation is probably > + helpful to other ports, which would be a case of simply removing the #if PLATFORM. I don't think you need to make excuses for this being here. > Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp:228 > + RefPtr<RenderSnapshottedPlugInBlurFilter> blurFilter = RenderSnapshottedPlugInBlurFilter::create(5); Please move the '5' into a named constant.
Jon Lee
Comment 5 2013-01-14 16:51:58 PST
Comment on attachment 182655 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182655&action=review > Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp:69 > + virtual FloatRect sourceImageRect() const { return m_sourceImageRect; } OVERRIDE keyword? > Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp:70 > + virtual FloatRect filterRegion() const { return m_filterRegion; } OVERRIDE keyword?
Dean Jackson
Comment 6 2013-01-14 17:06:20 PST
Comment on attachment 182655 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182655&action=review >> Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp:69 >> + virtual FloatRect sourceImageRect() const { return m_sourceImageRect; } > > OVERRIDE keyword? No need in this case - the parent is pure virtual here.
Dean Jackson
Comment 7 2013-01-14 19:51:58 PST
Committed r139701: <http://trac.webkit.org/changeset/139701>
Note You need to log in before you can comment on or make changes to this bug.