Bug 106625

Summary: [BlackBerry] Enable concatenating headers with same field name
Product: WebKit Reporter: Mary Wu <mawu>
Component: PlatformAssignee: Mary Wu <mawu>
Status: RESOLVED FIXED    
Severity: Normal CC: charles.wei, joenotcharles, mifenton, rwlbuis, staikos, tonikitoo, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Mary Wu
Reported 2013-01-10 19:05:30 PST
RFC 2616 says: Multiple message-header fields with the same field-name MAY be present in a message if and only if the entire field-value for that header field is defined as a comma-separated list [i.e., #(values)]. It MUST be possible to combine the multiple header fields into one "field-name: field-value" pair, without changing the semantics of the message, by appending each subsequent field-value to the first, each separated by a comma. The order in which header fields with the same field-name are received is therefore significant to the interpretation of the combined field value, and thus a proxy MUST NOT change the order of these field values when a message is forwarded.
Attachments
Patch (3.83 KB, patch)
2013-01-10 19:16 PST, Mary Wu 		no flags
DetailsFormatted DiffDiff
Patch (3.77 KB, patch)
2013-01-11 00:55 PST, Mary Wu 		no flags
DetailsFormatted DiffDiff
Patch (3.78 KB, patch)
2013-01-11 02:33 PST, Mary Wu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mary Wu
Comment 1 2013-01-10 19:16:42 PST
Created attachment 182244 [details] Patch
Mary Wu
Comment 2 2013-01-11 00:55:38 PST
Created attachment 182286 [details] Patch
Rob Buis
Comment 3 2013-01-11 01:53:51 PST
Comment on attachment 182286 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182286&action=review > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:69 > +static bool isAppendableHeader(String key) More efficient to use const String & here.
Mary Wu
Comment 4 2013-01-11 02:27:22 PST
(In reply to comment #3) > (From update of attachment 182286 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=182286&action=review > > > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:69 > > +static bool isAppendableHeader(String key) > > More efficient to use const String & here. nice catch, thanks
Mary Wu
Comment 5 2013-01-11 02:33:16 PST
Created attachment 182303 [details] Patch
Rob Buis
Comment 6 2013-01-11 02:35:01 PST
Comment on attachment 182303 [details] Patch LGTM.
WebKit Review Bot
Comment 7 2013-01-11 03:13:42 PST
Comment on attachment 182303 [details] Patch Clearing flags on attachment: 182303 Committed r139423: <http://trac.webkit.org/changeset/139423>
WebKit Review Bot
Comment 8 2013-01-11 03:13:45 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.