Bug 106619

Summary: Plugin snapshot label should take device resolution and inset into account
Product: WebKit Reporter: Dean Jackson <dino>
Component: Plug-insAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, jonlee, ojan.autocc, simon.fraser, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch simon.fraser: review+

Dean Jackson
Reported 2013-01-10 17:01:18 PST
The label image we draw for snapshotted plugins needs to be aware of device resolution. It also needs to take the inset of the image into account (say it has a drop shadow).
Attachments
Patch (3.57 KB, patch)
2013-01-10 17:05 PST, Dean Jackson 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2013-01-10 17:02:03 PST
<rdar://problem/12878149>
Dean Jackson
Comment 2 2013-01-10 17:05:03 PST
Created attachment 182227 [details] Patch
WebKit Review Bot
Comment 3 2013-01-10 17:08:14 PST
Attachment 182227 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp:184: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp:185: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp:186: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Simon Fraser (smfr)
Comment 4 2013-01-10 17:37:40 PST
Comment on attachment 182227 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182227&action=review > Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp:46 > +static const int startLabelInset = 20; // But the label is inset from its box also. FIXME: This will be removed when we go to a ShadowDOM approach. That type of comment isn't very future-proof!
Dean Jackson
Comment 5 2013-01-10 18:02:50 PST
Committed r139392: <http://trac.webkit.org/changeset/139392>
Note You need to log in before you can comment on or make changes to this bug.