| Summary: | Plugin snapshot label should take device resolution and inset into account | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||
| Component: | Plug-ins | Assignee: | Dean Jackson <dino> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | eric, jonlee, ojan.autocc, simon.fraser, webkit.review.bot | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Dean Jackson
2013-01-10 17:01:18 PST
Created attachment 182227 [details]
Patch
Attachment 182227 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp:184: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp:185: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp:186: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 3 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 182227 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182227&action=review > Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp:46 > +static const int startLabelInset = 20; // But the label is inset from its box also. FIXME: This will be removed when we go to a ShadowDOM approach. That type of comment isn't very future-proof! Committed r139392: <http://trac.webkit.org/changeset/139392> |