Bug 106617

Summary: Setting width overrides intrinsic min-width/max-width on flexboxes and their subclasses
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: eae, eric, esprehn, hyatt, leviw, mifenton, ojan.autocc, tkent, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 106143, 106675    
Attachments:
Description Flags
Patch tony: review+

Ojan Vafai
Reported 2013-01-10 16:38:04 PST
Setting width overrides intrinsic min-width/max-width on flexboxes and their subclasses
Attachments
Patch (29.45 KB, patch)
2013-01-10 16:41 PST, Ojan Vafai 		tony: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2013-01-10 16:41:48 PST
Created attachment 182225 [details] Patch
Tony Chang
Comment 2 2013-01-11 13:56:25 PST
Comment on attachment 182225 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182225&action=review > Source/WebCore/ChangeLog:9 > + classes that override computePrefferedLogicalWidths so that RenderBox can use Preffered -> Preferred > Source/WebCore/rendering/RenderBox.cpp:2064 > + if (logicalWidth.type() == FillAvailable) > + return logicalWidthResult; > + > + if (widthType == MainOrPreferredSize && sizesLogicalWidthToFitContent(widthType)) I see, you're saying that sizesLogicalWidthToFitContent doesn't make sense for min-width or max-width, right? I would probably have kept the != FillAvailable in the same condition, but this seems OK too.
Ojan Vafai
Comment 3 2013-01-11 18:22:51 PST
Committed r139535: <http://trac.webkit.org/changeset/139535>
Note You need to log in before you can comment on or make changes to this bug.