| Summary: | Setting width overrides intrinsic min-width/max-width on flexboxes and their subclasses | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ojan Vafai <ojan> | ||||
| Component: | New Bugs | Assignee: | Ojan Vafai <ojan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | eae, eric, esprehn, hyatt, leviw, mifenton, ojan.autocc, tkent, tony, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 106143, 106675 | ||||||
| Attachments: |
|
||||||
|
Description
Ojan Vafai
2013-01-10 16:38:04 PST
Created attachment 182225 [details]
Patch
Comment on attachment 182225 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182225&action=review > Source/WebCore/ChangeLog:9 > + classes that override computePrefferedLogicalWidths so that RenderBox can use Preffered -> Preferred > Source/WebCore/rendering/RenderBox.cpp:2064 > + if (logicalWidth.type() == FillAvailable) > + return logicalWidthResult; > + > + if (widthType == MainOrPreferredSize && sizesLogicalWidthToFitContent(widthType)) I see, you're saying that sizesLogicalWidthToFitContent doesn't make sense for min-width or max-width, right? I would probably have kept the != FillAvailable in the same condition, but this seems OK too. Committed r139535: <http://trac.webkit.org/changeset/139535> |