Bug 106610

Summary: [clean up] Remove HTMLFormElement::AutocompleteResultError in favor of more specific Error reasons
Product: WebKit Reporter: Dan Beam <dbeam>
Component: FormsAssignee: Dan Beam <dbeam>
Status: RESOLVED FIXED    
Severity: Trivial CC: abarth, dglazkov, fishd, jamesr, mifenton, ojan.autocc, tkent, tkent+wkapi, webkit.review.bot
Priority: P4    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: http://trac.webkit.org/changeset/139372
Bug Depends on:    
Bug Blocks: 100560    
Attachments:
Description Flags
Patch
none
rebase, cq+ if lgty none

Dan Beam
Reported 2013-01-10 15:15:52 PST
Essentially I need to fix all the FIXMEs I introduced here <http://trac.webkit.org/changeset/139372> by removing a public enum value when nobody's using it any more. I left it in to keep chrome compiling. After I switch it in chrome code (https://chromiumcodereview.appspot.com/11821020/) it wont be used anywhere as far as I know.
Attachments
Patch (4.92 KB, patch)
2013-01-11 17:12 PST, Dan Beam 		no flags
DetailsFormatted DiffDiff
rebase, cq+ if lgty (4.93 KB, patch)
2013-01-11 17:54 PST, Dan Beam 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dan Beam
Comment 1 2013-01-11 17:12:10 PST
Created attachment 182449 [details] Patch
WebKit Review Bot
Comment 2 2013-01-11 17:23:27 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Dan Beam
Comment 3 2013-01-11 17:54:11 PST
Created attachment 182454 [details] rebase, cq+ if lgty
WebKit Review Bot
Comment 4 2013-01-11 23:04:43 PST
Comment on attachment 182454 [details] rebase, cq+ if lgty Clearing flags on attachment: 182454 Committed r139545: <http://trac.webkit.org/changeset/139545>
WebKit Review Bot
Comment 5 2013-01-11 23:04:48 PST
All reviewed patches have been landed. Closing bug.
Dan Beam
Comment 6 2013-01-21 00:46:32 PST
Thanks for landing for me, Darin!
Note You need to log in before you can comment on or make changes to this bug.