Bug 106605

Summary: IndexedDB: Remove IDBObjectStore/IndexBackendImpl and support functions
Product: WebKit Reporter: Alec Flett <alecflett>
Component: New BugsAssignee: Alec Flett <alecflett>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, jamesr, peter+ews, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing
none
Patch for landing none

Description Alec Flett 2013-01-10 14:39:03 PST
IndexedDB: Remove IDBObjectStore/IndexBackendImpl and support functions
Comment 1 Alec Flett 2013-01-10 14:47:34 PST
Created attachment 182213 [details]
Patch
Comment 2 Alec Flett 2013-01-10 14:47:58 PST
Note that this won't compile against chromium until https://codereview.chromium.org/11828054 lands.
Comment 3 WebKit Review Bot 2013-01-10 14:58:26 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 WebKit Review Bot 2013-01-10 15:22:44 PST
Comment on attachment 182213 [details]
Patch

Attachment 182213 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15810065
Comment 5 Peter Beverloo (cr-android ews) 2013-01-10 16:11:41 PST
Comment on attachment 182213 [details]
Patch

Attachment 182213 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/15803139
Comment 6 Alec Flett 2013-01-11 11:13:09 PST
Created attachment 182376 [details]
Patch for landing
Comment 7 WebKit Review Bot 2013-01-11 11:29:04 PST
Comment on attachment 182376 [details]
Patch for landing

Rejecting attachment 182376 [details] from commit-queue.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
pts/build-webkit', '--release', '--chromium', '--update-chromium']" exit_code: 2
urityOrigin&, WebKit::WebFrame*, const WebKit::WebString&)
cc1plus: warnings being treated as errors
At global scope:
cc1plus: error: unrecognized command line option "-Wno-narrowing"
cc1plus: error: unrecognized command line option "-Wno-narrowing"
make: *** [out/Release/obj.target/webkit_support/Source/WebKit/chromium/webkit/support/test_webkit_platform_support.o] Error 1
make: *** Waiting for unfinished jobs....

Full output: http://queues.webkit.org/results/15801552
Comment 8 Alec Flett 2013-01-11 11:49:21 PST
sigh. I think that issue was because that build hadn't picked up the latest chromium, which fixes that. Gonna wait a bit and try again.
Comment 9 WebKit Review Bot 2013-01-11 12:17:48 PST
Comment on attachment 182376 [details]
Patch for landing

Attachment 182376 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15806474
Comment 10 Peter Beverloo (cr-android ews) 2013-01-11 12:43:02 PST
Comment on attachment 182376 [details]
Patch for landing

Attachment 182376 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/15804476
Comment 11 Alec Flett 2013-01-13 22:00:21 PST
Comment on attachment 182376 [details]
Patch for landing

ok, chromium stuff that I missed before has now finally landed.
Comment 12 WebKit Review Bot 2013-01-13 22:31:18 PST
Comment on attachment 182376 [details]
Patch for landing

Rejecting attachment 182376 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
eue/Source/WebKit/chromium/third_party/libjingle/source --revision 257 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
41>At revision 257.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/15853392
Comment 13 Alec Flett 2013-01-14 11:05:34 PST
Created attachment 182602 [details]
Patch for landing
Comment 14 WebKit Review Bot 2013-01-14 11:36:13 PST
Comment on attachment 182602 [details]
Patch for landing

Rejecting attachment 182602 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
queue/Source/WebKit/chromium/third_party/skia/include --revision 7126 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
47>At revision 7126.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/15867570
Comment 15 Adam Barth 2013-01-14 12:19:30 PST
Comment on attachment 182602 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=182602&action=review

> Source/WebCore/ChangeLog:11
> +        No new tests (OOPS!).

The following ChangeLog files contain OOPS:

        trunk/Source/WebCore/ChangeLog

    Please don't ever say "OOPS" in a ChangeLog file.
Comment 16 Alec Flett 2013-01-14 13:28:15 PST
Created attachment 182617 [details]
Patch for landing
Comment 17 WebKit Review Bot 2013-01-14 14:41:52 PST
Comment on attachment 182617 [details]
Patch for landing

Clearing flags on attachment: 182617

Committed r139666: <http://trac.webkit.org/changeset/139666>
Comment 18 WebKit Review Bot 2013-01-14 14:41:57 PST
All reviewed patches have been landed.  Closing bug.