Bug 106604

Summary: [chromium] Don't regenerate all bindings when any idl file changes
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, haraken, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Tony Chang
Reported 2013-01-10 14:25:14 PST
[chromium] Don't regenerate all bindings when any idl file changes
Attachments
Patch (6.74 KB, patch)
2013-01-10 14:36 PST, Tony Chang 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2013-01-10 14:36:12 PST
Created attachment 182212 [details] Patch
Tony Chang
Comment 2 2013-01-10 14:42:33 PST
What do you two think of this approach? This is similar to https://bugs.webkit.org/show_bug.cgi?id=89125 but as Haraken mentions, most build systems can't generate dependencies while they are running like make can (evan says that ninja can't do this). This isn't quite as sophisticated (we still regenerate all the bindings sometimes), but not nearly as often. I'm not sure how to do this with qmake or cmake, although Maciej's patch could be applied to the GTK+ build since it uses make.
Kentaro Hara
Comment 3 2013-01-11 00:20:06 PST
Comment on attachment 182212 [details] Patch I think this is a good approach to practically solving the all-idl-files-rebuild problem. Thanks for the great patch!
WebKit Review Bot
Comment 4 2013-01-11 14:09:56 PST
Comment on attachment 182212 [details] Patch Clearing flags on attachment: 182212 Committed r139494: <http://trac.webkit.org/changeset/139494>
WebKit Review Bot
Comment 5 2013-01-11 14:09:59 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.