Bug 106591

Summary:

Flexboxes incorrectly add the scrollbar width to the intrinsic width of fixed-width items

Product:

WebKit

Reporter:

Ojan Vafai <ojan>

Component:

New Bugs

Assignee:

Ojan Vafai <ojan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eae, eric, esprehn, jchaffraix, leviw, ojan.autocc, tony, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

106143

Attachments:

Description	Flags
Patch	leviw: review+

Description Ojan Vafai 2013-01-10 11:59:32 PST

Flexboxes incorrectly add the scrollbar width to the intrinsic width of fixed-width items

Comment 1 Ojan Vafai 2013-01-10 12:01:18 PST

Created attachment 182187 [details]
Patch

Comment 2 Levi Weintraub 2013-01-10 12:14:55 PST

Comment on attachment 182187 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182187&action=review

> Source/WebCore/ChangeLog:27
> +        * rendering/RenderGrid.cpp:
> +        (WebCore::RenderGrid::computePreferredLogicalWidths):

Nit: a short summary would be nice for the changes, especially calling out that you're only adding a FIXME to RenderGrid.

Comment 3 Ojan Vafai 2013-01-10 12:33:45 PST

Committed r139351: <http://trac.webkit.org/changeset/139351>