Bug 106590

Summary: Add Mac WK2 EWS bots
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, andersca, dpranke, eric, jberlin, lforschler, slewis, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Adds MacWK2EWS class to earlywarningsystem.py
none
Also update QueueStatusServer
none
Added MacWK2Port abarth: review+

Ryosuke Niwa
Reported 2013-01-10 11:49:56 PST
We got more Mac minis!
Attachments
Adds MacWK2EWS class to earlywarningsystem.py (2.08 KB, patch)
2013-01-10 11:54 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Also update QueueStatusServer (2.54 KB, patch)
2013-01-10 12:02 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Added MacWK2Port (3.63 KB, patch)
2013-01-10 13:16 PST, Ryosuke Niwa 		abarth: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-01-10 11:54:22 PST
Created attachment 182183 [details] Adds MacWK2EWS class to earlywarningsystem.py
Ryosuke Niwa
Comment 2 2013-01-10 11:55:03 PST
Comment on attachment 182183 [details] Adds MacWK2EWS class to earlywarningsystem.py View in context: https://bugs.webkit.org/attachment.cgi?id=182183&action=review > Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py:220 > + port_name = "mac" Do I need to make this mac-wk2 instead?
Ryosuke Niwa
Comment 3 2013-01-10 12:02:39 PST
Created attachment 182188 [details] Also update QueueStatusServer
Ryosuke Niwa
Comment 4 2013-01-10 12:35:30 PST
Comment on attachment 182188 [details] Also update QueueStatusServer Missing some bits and pieces to support WK2. It appears to me that Qt EWS WK2 bots are doing exactly what Qt EWS bots do :(
Ryosuke Niwa
Comment 5 2013-01-10 13:16:08 PST
Created attachment 182196 [details] Added MacWK2Port
Ryosuke Niwa
Comment 6 2013-01-10 13:22:28 PST
Thanks for the review!
Ryosuke Niwa
Comment 7 2013-01-10 13:29:08 PST
Committed r139357: <http://trac.webkit.org/changeset/139357>
Ryosuke Niwa
Comment 8 2013-01-10 13:29:54 PST
Also see <rdar://problem/12991857>.
Ryosuke Niwa
Comment 9 2013-01-15 18:14:08 PST
Typo fixed in http://trac.webkit.org/changeset/139818.
Note You need to log in before you can comment on or make changes to this bug.