Bug 106546

Summary: Web Inspector: Native Memory Instrumentation: fix instrumentation for already instrumented classes 2/N
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, allan.jensen, apavlov, cmarcelo, eric.carlson, feature-media-reviews, haraken, japhet, keishi, loislo, macpherson, menard, noel.gordon, ojan.autocc, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 106550    
Bug Blocks:    
Attachments:
Description Flags
Patch vsevik: review+

Description Ilya Tikhonovsky 2013-01-10 03:15:37 PST 
next patch with fixes for the instrumented classes.
Comment 1 Ilya Tikhonovsky 2013-01-10 03:21:36 PST 
Created attachment 182105 [details]
Patch
Comment 2 Ilya Tikhonovsky 2013-01-10 03:41:54 PST 
landed as r139306
Comment 3 noel gordon 2013-01-10 04:14:44 PST 
Two inpector tests started crashing with this change, expected?

http://build.webkit.org/builders/Chromium%20Mac%20Release%20%28Tests%29/builds/31469

Regressions: Unexpected crashes (2)
  inspector-protocol/nmi-webaudio-leak-test.html [ Crash ]
  inspector-protocol/nmi-webaudio.html [ Crash ]
Comment 4 WebKit Review Bot 2013-01-10 04:22:08 PST 
Re-opened since this is blocked by bug 106550
Comment 5 Ilya Tikhonovsky 2013-01-14 00:23:23 PST 
Committed r139589: <http://trac.webkit.org/changeset/139589>