Bug 106527 – Should be able to tell EWS tool cold-boot.sh what the boot screen script should be

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Alan Cutter]

Currently "screen -t kr ./start-queue.sh QUEUE_TYPE BOT_ID" is the template for new bot instances.
To support other variants of bot instances the screen-config should be defined in its entirety.

[Alan Cutter]

Created attachment 182110 [details]
Patch

[WebKit Review Bot]

Comment on attachment 182110 [details]
Patch

Attachment 182110 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15766806

New failing tests:
inspector-protocol/nmi-webaudio-leak-test.html
inspector/profiler/memory-instrumentation-cached-images.html

[Eric Seidel (no email)]

Death by flaky tests!

[Adam Barth]

Comment on attachment 182110 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=182110&action=review

> Tools/ChangeLog:10
> +        Split cold-boot.sh script up into build-vm.sh, build-repo.sh and build-boot-cmd.sh.
> +        Updated GCE bot build scripts to match.
> +        Unable to test scripts directly as they depend on being in the repository to work!

Ideally a ChangeLog would explain the "why" behind a change rather than just the "what" you're changing.  My guess is that you're making this change to support building the style-queue and the sherrifbot on Google Compute Engine, but it would be nice if you added that information here so that others can understand your change too.

[WebKit Review Bot]

Comment on attachment 182110 [details]
Patch

Clearing flags on attachment: 182110

Committed r139354: <http://trac.webkit.org/changeset/139354>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.