Summary: | Should be able to tell EWS tool cold-boot.sh what the boot screen script should be | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alan Cutter <alancutter> | ||||
Component: | Tools / Tests | Assignee: | Alan Cutter <alancutter> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, alancutter, dglazkov, eric, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 106005 | ||||||
Attachments: |
|
Description
Alan Cutter
2013-01-09 20:40:18 PST
Created attachment 182110 [details]
Patch
Comment on attachment 182110 [details] Patch Attachment 182110 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15766806 New failing tests: inspector-protocol/nmi-webaudio-leak-test.html inspector/profiler/memory-instrumentation-cached-images.html Death by flaky tests! Comment on attachment 182110 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=182110&action=review > Tools/ChangeLog:10 > + Split cold-boot.sh script up into build-vm.sh, build-repo.sh and build-boot-cmd.sh. > + Updated GCE bot build scripts to match. > + Unable to test scripts directly as they depend on being in the repository to work! Ideally a ChangeLog would explain the "why" behind a change rather than just the "what" you're changing. My guess is that you're making this change to support building the style-queue and the sherrifbot on Google Compute Engine, but it would be nice if you added that information here so that others can understand your change too. Comment on attachment 182110 [details] Patch Clearing flags on attachment: 182110 Committed r139354: <http://trac.webkit.org/changeset/139354> All reviewed patches have been landed. Closing bug. |