Bug 106518

Summary: [chromium] Store scrollable layer's contents size for coordinated scrollable layers
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, dglazkov, enne, tonikitoo, vollick, wangxianzhu, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch enne: review+, webkit.review.bot: commit-queue-

James Robinson
Reported 2013-01-09 18:55:39 PST
[chromium] Store scrollable layer's contents size for coordinated scrollable layers
Attachments
Patch (2.14 KB, patch)
2013-01-09 18:59 PST, James Robinson 		enne: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2013-01-09 18:59:30 PST
Created attachment 182044 [details] Patch
WebKit Review Bot
Comment 2 2013-01-09 19:46:18 PST
Comment on attachment 182044 [details] Patch Attachment 182044 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15766657 New failing tests: platform/chromium/virtual/softwarecompositing/iframes/iframe-content-flipping.html compositing/iframes/iframe-content-flipping.html
James Robinson
Comment 3 2013-01-09 21:49:02 PST
(In reply to comment #2) > (From update of attachment 182044 [details]) > Attachment 182044 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/15766657 > > New failing tests: > platform/chromium/virtual/softwarecompositing/iframes/iframe-content-flipping.html > compositing/iframes/iframe-content-flipping.html I think the property set is causing a different number of frames to be painted, so this test (since it's a repaint test) has different levels of grey. This test is marked as failing on lion / molo referencing https://bugs.webkit.org/show_bug.cgi?id=81145. Will confirm on linux tomorrow.
James Robinson
Comment 4 2013-01-10 15:38:01 PST
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 182044 [details] [details]) > > Attachment 182044 [details] [details] did not pass chromium-ews (chromium-xvfb): > > Output: http://queues.webkit.org/results/15766657 > > > > New failing tests: > > platform/chromium/virtual/softwarecompositing/iframes/iframe-content-flipping.html > > compositing/iframes/iframe-content-flipping.html > > I think the property set is causing a different number of frames to be painted, so this test (since it's a repaint test) has different levels of grey. This test is marked as failing on lion / molo referencing https://bugs.webkit.org/show_bug.cgi?id=81145. Will confirm on linux tomorrow. That's exactly it. I think this is due mostly to testRunner.display() forcing us into the composite path synchronously, I doubt this has any impact on real users. I'll mark these as needing rebase when landing.
Adrienne Walker
Comment 5 2013-01-10 15:50:03 PST
Comment on attachment 182044 [details] Patch R=me. Thanks for investigating the test failures.
James Robinson
Comment 6 2013-01-10 16:08:40 PST
Committed r139385: <http://trac.webkit.org/changeset/139385>
Note You need to log in before you can comment on or make changes to this bug.