Summary: | [chromium] Store scrollable layer's contents size for coordinated scrollable layers | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | James Robinson <jamesr> | ||||
Component: | New Bugs | Assignee: | James Robinson <jamesr> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, dglazkov, enne, tonikitoo, vollick, wangxianzhu, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
James Robinson
2013-01-09 18:55:39 PST
Created attachment 182044 [details]
Patch
Comment on attachment 182044 [details] Patch Attachment 182044 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15766657 New failing tests: platform/chromium/virtual/softwarecompositing/iframes/iframe-content-flipping.html compositing/iframes/iframe-content-flipping.html (In reply to comment #2) > (From update of attachment 182044 [details]) > Attachment 182044 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/15766657 > > New failing tests: > platform/chromium/virtual/softwarecompositing/iframes/iframe-content-flipping.html > compositing/iframes/iframe-content-flipping.html I think the property set is causing a different number of frames to be painted, so this test (since it's a repaint test) has different levels of grey. This test is marked as failing on lion / molo referencing https://bugs.webkit.org/show_bug.cgi?id=81145. Will confirm on linux tomorrow. (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 182044 [details] [details]) > > Attachment 182044 [details] [details] did not pass chromium-ews (chromium-xvfb): > > Output: http://queues.webkit.org/results/15766657 > > > > New failing tests: > > platform/chromium/virtual/softwarecompositing/iframes/iframe-content-flipping.html > > compositing/iframes/iframe-content-flipping.html > > I think the property set is causing a different number of frames to be painted, so this test (since it's a repaint test) has different levels of grey. This test is marked as failing on lion / molo referencing https://bugs.webkit.org/show_bug.cgi?id=81145. Will confirm on linux tomorrow. That's exactly it. I think this is due mostly to testRunner.display() forcing us into the composite path synchronously, I doubt this has any impact on real users. I'll mark these as needing rebase when landing. Comment on attachment 182044 [details]
Patch
R=me. Thanks for investigating the test failures.
Committed r139385: <http://trac.webkit.org/changeset/139385> |