Bug 106503

Summary: Speed up supplemental dependency computation
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, gyuyoung.kim, haraken, japhet, rakuco, webkit.review.bot, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 110285    
Attachments:
Description Flags
Patch
none
Patch for landing none

Tony Chang
Reported 2013-01-09 16:52:56 PST
Speed up supplemental dependency computation
Attachments
Patch (31.55 KB, patch)
2013-01-09 17:07 PST, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch for landing (31.52 KB, patch)
2013-01-10 10:06 PST, Tony Chang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2013-01-09 17:07:52 PST
Created attachment 182018 [details] Patch
Tony Chang
Comment 2 2013-01-09 17:10:42 PST
I may need to fix up some of the other builds. Note that while IDLParser.pm seems to be able to handle multiple interfaces in the same idl file, we make assumptions that there is only a single interface per file. This was true before this patch (e.g., $interfaceNameToIdlFile and $idlFileToInterfaceName assumes there is a 1-to-1 mapping between idl file and interface name).
WebKit Review Bot
Comment 3 2013-01-10 09:45:21 PST
Comment on attachment 182018 [details] Patch Rejecting attachment 182018 [details] from commit-queue. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: t-queue/Source/WebKit/chromium/third_party/smhasher/src --revision 147 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 51>At revision 147. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/15804023
Tony Chang
Comment 4 2013-01-10 10:06:29 PST
Created attachment 182163 [details] Patch for landing
WebKit Review Bot
Comment 5 2013-01-10 10:26:31 PST
Comment on attachment 182163 [details] Patch for landing Clearing flags on attachment: 182163 Committed r139331: <http://trac.webkit.org/changeset/139331>
WebKit Review Bot
Comment 6 2013-01-10 10:26:35 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.