Bug 106492

Summary: Add Gregg Tavares as a committer
Product: WebKit Reporter: Gregg Tavares <gman>
Component: Tools / TestsAssignee: Gregg Tavares <gman>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ap: review-

Gregg Tavares
Reported 2013-01-09 14:44:25 PST
Add Gregg Tavares as a committer
Attachments
Patch (2.00 KB, patch)
2013-01-09 14:45 PST, Gregg Tavares 		no flags
DetailsFormatted DiffDiff
Patch (2.00 KB, patch)
2013-01-09 14:52 PST, Gregg Tavares 		ap: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gregg Tavares
Comment 1 2013-01-09 14:45:16 PST
Created attachment 181985 [details] Patch
WebKit Review Bot
Comment 2 2013-01-09 14:46:26 PST
Comment on attachment 181985 [details] Patch Rejecting attachment 181985 [details] from commit-queue. gman@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
Gregg Tavares
Comment 3 2013-01-09 14:52:25 PST
Created attachment 181989 [details] Patch
Gregg Tavares
Comment 4 2013-01-09 15:14:41 PST
Committed r139247: <http://trac.webkit.org/changeset/139247>
Eric Seidel (no email)
Comment 5 2013-01-09 15:36:16 PST
Fantastic! Welcome to the party! Now the CQ will recognize you as a committer (once it restarts, which it does about every 2 hours).
Alexey Proskuryakov
Comment 6 2013-01-09 16:51:22 PST
Comment on attachment 181989 [details] Patch Such changes do not require review.
Note You need to log in before you can comment on or make changes to this bug.