Bug 106486

Summary: [BlackBerry] Handle the case that start/end position is out of unclipped selection region
Product: WebKit Reporter: Yongxin Dai <yodai>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, rwlbuis, tonikitoo, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Yongxin Dai
Reported 2013-01-09 13:23:14 PST
Unclipped selection region should cover start/end position of the selection. Since we exclude hidden text when calculating unclipped selection region, the start/end position can be out of unclipped selection region if it is for hidden text. If that is the case, start/end handle will be invisible. To avoid invisible handle, we take unclipped selection region as reference rectangle in the case.
Attachments
Patch (2.23 KB, patch)
2013-01-09 13:40 PST, Yongxin Dai 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yongxin Dai
Comment 1 2013-01-09 13:40:08 PST
Created attachment 181977 [details] Patch
Rob Buis
Comment 2 2013-01-10 01:13:14 PST
Comment on attachment 181977 [details] Patch LGTM.
WebKit Review Bot
Comment 3 2013-01-10 01:16:31 PST
Comment on attachment 181977 [details] Patch Clearing flags on attachment: 181977 Committed r139295: <http://trac.webkit.org/changeset/139295>
WebKit Review Bot
Comment 4 2013-01-10 01:16:35 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.