Bug 106472

Summary: IndexedDB: Remove unnecessary tests from storage/indexeddb/key-type-array.html
Product: WebKit Reporter: Michael Pruett <michael>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, benjamin, jsbell, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Michael Pruett
Reported 2013-01-09 10:43:59 PST
The tests in storage/indexeddb/key-type-array.html which verify that JSON.stringify() throws an exception for cyclic objects are unnecessary and differ between JSC and V8. The error message regarding serializing cyclic structures in JSC is "JSON.stringify cannot serialize cyclic structures." (Source/JavaScriptCore/runtime/JSONObject.cpp line 412) while the comparable error message in V8 is "Converting circular structure to JSON" (v8/src/messages.js line 116). The error messages relating to serializing cyclic structures are rather incidental to the functionality being tested: shouldThrow("JSON.stringify(cyclic_array)"); These tests should be removed.
Attachments
Patch (3.71 KB, patch)
2013-01-09 10:49 PST, Michael Pruett 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Pruett
Comment 1 2013-01-09 10:49:14 PST
Created attachment 181949 [details] Patch
Joshua Bell
Comment 2 2013-01-09 10:54:42 PST
Comment on attachment 181949 [details] Patch lgtm
WebKit Review Bot
Comment 3 2013-01-09 12:13:24 PST
Comment on attachment 181949 [details] Patch Clearing flags on attachment: 181949 Committed r139219: <http://trac.webkit.org/changeset/139219>
WebKit Review Bot
Comment 4 2013-01-09 12:13:27 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.