| Summary: | IndexedDB: Remove unnecessary tests from storage/indexeddb/key-type-array.html | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Pruett <michael> | ||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | alecflett, benjamin, jsbell, tony, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 181949 [details]
Patch
Comment on attachment 181949 [details]
Patch
lgtm
Comment on attachment 181949 [details] Patch Clearing flags on attachment: 181949 Committed r139219: <http://trac.webkit.org/changeset/139219> All reviewed patches have been landed. Closing bug. |
The tests in storage/indexeddb/key-type-array.html which verify that JSON.stringify() throws an exception for cyclic objects are unnecessary and differ between JSC and V8. The error message regarding serializing cyclic structures in JSC is "JSON.stringify cannot serialize cyclic structures." (Source/JavaScriptCore/runtime/JSONObject.cpp line 412) while the comparable error message in V8 is "Converting circular structure to JSON" (v8/src/messages.js line 116). The error messages relating to serializing cyclic structures are rather incidental to the functionality being tested: shouldThrow("JSON.stringify(cyclic_array)"); These tests should be removed.