Bug 106472

Summary: IndexedDB: Remove unnecessary tests from storage/indexeddb/key-type-array.html
Product: WebKit Reporter: Michael Pruett <michael>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: alecflett, benjamin, jsbell, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch none

Description Michael Pruett 2013-01-09 10:43:59 PST
The tests in storage/indexeddb/key-type-array.html which verify that JSON.stringify() throws an exception for cyclic objects are unnecessary and differ between JSC and V8.

The error message regarding serializing cyclic structures in JSC is "JSON.stringify cannot serialize cyclic structures." (Source/JavaScriptCore/runtime/JSONObject.cpp line 412) while the comparable error message in V8 is "Converting circular structure to JSON" (v8/src/messages.js line 116).

The error messages relating to serializing cyclic structures are rather incidental to the functionality being tested:


These tests should be removed.
Comment 1 Michael Pruett 2013-01-09 10:49:14 PST
Created attachment 181949 [details]
Comment 2 Joshua Bell 2013-01-09 10:54:42 PST
Comment on attachment 181949 [details]

Comment 3 WebKit Review Bot 2013-01-09 12:13:24 PST
Comment on attachment 181949 [details]

Clearing flags on attachment: 181949

Committed r139219: <http://trac.webkit.org/changeset/139219>
Comment 4 WebKit Review Bot 2013-01-09 12:13:27 PST
All reviewed patches have been landed.  Closing bug.