| Summary: | Add WebPreferences for Seamless IFrames on Windows port. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Roger Fong <roger_fong> | ||||
| Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | eric, mkwst, roger_fong, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | Windows 7 | ||||||
| Attachments: |
|
||||||
|
Description
Roger Fong
2013-01-09 10:20:54 PST
This arose from https://bugs.webkit.org/show_bug.cgi?id=106213 Created attachment 181945 [details]
patch
Attachment 181945 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/win/ChangeLog', u'Source/Web..." exit_code: 1
Source/WebKit/win/WebPreferences.h:173: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Source/WebKit/win/WebPreferences.h:176: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 2 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #3) > Attachment 181945 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/win/ChangeLog', u'Source/Web..." exit_code: 1 > Source/WebKit/win/WebPreferences.h:173: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] > Source/WebKit/win/WebPreferences.h:176: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] > Total errors found: 2 in 6 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. Just the standard way of declaring the method in WebPreferences.h, not a valid error. Comment on attachment 181945 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=181945&action=review rs=me. Sorry for the trouble. > Source/WebKit/win/WebPreferenceKeysPrivate.h:116 > +#define SeamlessIFramesPreferenceKey "SeamlessIFramesPreferenceKey" // default: false I'm not sure if you want these off by default or not. (In reply to comment #5) > (From update of attachment 181945 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=181945&action=review > > rs=me. Sorry for the trouble. No worries :) > > Source/WebKit/win/WebPreferenceKeysPrivate.h:116 > > +#define SeamlessIFramesPreferenceKey "SeamlessIFramesPreferenceKey" // default: false > > I'm not sure if you want these off by default or not. Hmm me neither, just went with the flow on this one. The flag in RunTimeEnabledFeatures was intialized to false so I just went with it... |