Bug 106447

Summary: [WK2] Missing HAVE(ACCESSIBILITY) guards to some atk/ accessibility files.
Product: WebKit Reporter: Krzysztof Czech <k.czech>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, dmazzoni, g.czajkowski, gyuyoung.kim, jdiggs, laszlo.gombos, lucas.de.marchi, mrobinson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Linux   
Bug Depends on: 106290    
Bug Blocks: 106216    
Attachments:
Description Flags
[EFL] Missing HAVE(ACCESSIBILITY) guards to some atk/ accessibility files.
none
[EFL] Missing HAVE(ACCESSIBILITY) guards to some atk/ accessibility files.
none
[EFL] Missing HAVE(ACCESSIBILITY) guards to some atk/ accessibility files.
none
[EFL][WK2] Missing HAVE(ACCESSIBILITY) guards to some atk/ accessibility files.
none
[WK2] Missing HAVE(ACCESSIBILITY) guards to some atk/ accessibility files. none

Description Krzysztof Czech 2013-01-09 06:05:08 PST
Some accessibility/atk headers still missing HAVE(ACCESSIBILITY) guards.
This will cause build errors.
Comment 1 Krzysztof Czech 2013-01-09 06:06:55 PST
Created attachment 181906 [details]
[EFL] Missing HAVE(ACCESSIBILITY) guards to some atk/ accessibility files.
Comment 2 Krzysztof Czech 2013-01-09 06:37:43 PST
Created attachment 181914 [details]
[EFL] Missing HAVE(ACCESSIBILITY) guards to some atk/ accessibility files.
Comment 3 Krzysztof Czech 2013-01-09 06:45:57 PST
Created attachment 181915 [details]
[EFL] Missing HAVE(ACCESSIBILITY) guards to some atk/ accessibility files.
Comment 4 Gyuyoung Kim 2013-01-09 06:52:01 PST
Comment on attachment 181915 [details]
[EFL] Missing HAVE(ACCESSIBILITY) guards to some atk/ accessibility files.

View in context: https://bugs.webkit.org/attachment.cgi?id=181915&action=review

> Source/WebKit2/ChangeLog:3
> +        [EFL] Missing HAVE(ACCESSIBILITY) guards to some atk/ accessibility files.

This is not EFL specific patch. It looks [WK2] is more appropriate.
Comment 5 Krzysztof Czech 2013-01-09 07:03:17 PST
Created attachment 181919 [details]
[EFL][WK2] Missing HAVE(ACCESSIBILITY) guards to some atk/ accessibility files.
Comment 6 Krzysztof Czech 2013-01-09 07:03:58 PST
Done.

(In reply to comment #4)
> (From update of attachment 181915 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=181915&action=review
> 
> > Source/WebKit2/ChangeLog:3
> > +        [EFL] Missing HAVE(ACCESSIBILITY) guards to some atk/ accessibility files.
> 
> This is not EFL specific patch. It looks [WK2] is more appropriate.
Comment 7 Krzysztof Czech 2013-01-11 01:18:44 PST
Created attachment 182292 [details]
[WK2] Missing HAVE(ACCESSIBILITY) guards to some atk/ accessibility files.
Comment 8 Grzegorz Czajkowski 2013-01-11 01:48:48 PST
LGTM.
Comment 9 WebKit Review Bot 2013-01-11 02:31:38 PST
Comment on attachment 182292 [details]
[WK2] Missing HAVE(ACCESSIBILITY) guards to some atk/ accessibility files.

Clearing flags on attachment: 182292

Committed r139421: <http://trac.webkit.org/changeset/139421>
Comment 10 WebKit Review Bot 2013-01-11 02:31:44 PST
All reviewed patches have been landed.  Closing bug.