| Summary: | min-content gets the wrong value if min-width is set on some form controls | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ojan Vafai <ojan> | ||||||
| Component: | New Bugs | Assignee: | Ojan Vafai <ojan> | ||||||
| Status: | REOPENED --- | ||||||||
| Severity: | Normal | CC: | ahmad.saleem792, bdakin, dglazkov, eric, esprehn, hyatt, jchaffraix, mifenton, ojan.autocc, tkent, tony, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Ojan Vafai
2013-01-08 15:04:20 PST
Created attachment 181778 [details]
Patch
Comment on attachment 181778 [details] Patch Attachment 181778 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15763279 New failing tests: fast/forms/min-content-form-controls.html Comment on attachment 181778 [details] Patch Attachment 181778 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15759328 New failing tests: fast/forms/min-content-form-controls.html Created attachment 181806 [details]
Patch
Comment on attachment 181806 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181806&action=review > Source/WebCore/rendering/RenderFileUploadControl.cpp:198 > > + Nit: Extra blank line? Committed r139216: <http://trac.webkit.org/changeset/139216> The new test is being complained about by Mac/Chromium bots: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fforms%2Fmin-content-form-controls.html I took the test from the patch (it was also on source.chromium.org) and then tested it in Safari Technology Preview 163 and it passes all test: Test Case - https://www.youtube.com/watch?v=AxYezM4XJ3o Do we need anything else? Thanks! (In reply to Ahmad Saleem from comment #9) > I took the test from the patch (it was also on source.chromium.org) and then > tested it in Safari Technology Preview 163 and it passes all test: > > Test Case - https://www.youtube.com/watch?v=AxYezM4XJ3o > > Do we need anything else? Thanks! https://jsfiddle.net/0mnpues3/show |