Bug 106337
| Summary: | [ATK][WK2] accessibility/aria-help.html is failing | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Zan Dobersek <zan> |
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | berto, k.czech, mario |
| Priority: | P2 | Keywords: | Gtk, LayoutTestFailure |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 98347 | ||
Zan Dobersek
The accessibility/aria-help.html layout test is failing on GTK WK2 port.
Here's the diff:
--- /home/zan/Dev/webkit/webkit/WebKitBuild/Release/layout-test-results/accessibility/aria-help-expected.txt
+++ /home/zan/Dev/webkit/webkit/WebKitBuild/Release/layout-test-results/accessibility/aria-help-actual.txt
@@ -4,7 +4,7 @@
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-PASS button.helpText is 'AXHelp: click here'
+FAIL button.helpText should be AXHelp: click here. Was .
PASS successfullyParsed is true
TEST COMPLETE
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alberto Garcia
That's because AccessibilityUIElement::helpText() is not implemented.
Mario Sanchez Prada
*** Bug 112028 has been marked as a duplicate of this bug. ***
Mario Sanchez Prada
(In reply to comment #1)
> That's because AccessibilityUIElement::helpText() is not implemented.
Exactly. And turns out that it should not be implemented because both helpText() and aria-help are Mac specific things neither defined in the W3C specs nor applicable to ATK at all.
That said, it's true that support for helpText() has been added in the past to DRT (I did), but that was before realizing that it was a Mac specific thing and using the DumpRenderTreeSupport thing, which is something that we don't have in WK2.
So, the true solution to this is not to implement this function, but to move the tests using it to platform/mac/accessibility, remove the whole support for helpText() from DRT, remove the mapping of aria-help into an 'aria-help' AtkObject attribute in WebKitAccesibilityWrapperAtk (which is wrong as well), and stop worrying about this once and for all.
Mario Sanchez Prada
*** Bug 106336 has been marked as a duplicate of this bug. ***
Mario Sanchez Prada
Changing title to reflect it's not a thing exclusive to GTK
Mario Sanchez Prada
This issue will be dealt with as part of this new bug I've just filed
*** This bug has been marked as a duplicate of bug 121675 ***