Bug 106317

Summary: [Qt] Fix libxml2 config test
Product: WebKit Reporter: Heikki Paajanen <hepaajan>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, hausmann, vestbo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Linux   
Attachments:
Description Flags
[Qt] Fix libxml2 config test none

Description Heikki Paajanen 2013-01-08 02:55:19 PST
Tools/qmake/config.tests/libxml2/libxml2.cpp assumes that libxml2 headers are in already included directory under libxml2 sub-directory.
This is not always true.
Comment 1 Heikki Paajanen 2013-01-08 02:58:03 PST
Created attachment 181680 [details]
[Qt] Fix libxml2 config test

Fix include in libxml2 config test
Comment 2 Andras Becsi 2013-01-08 03:15:13 PST
Comment on attachment 181680 [details]
[Qt] Fix libxml2 config test

LGTM.
This should also work on mac which does not have pkgconfig, but we add /usr/include/libxml2 to the includepath.
Comment 3 Simon Hausmann 2013-01-08 04:00:46 PST
Andras, this looks like something worth for backporting into stable. Do you have time to do it after landing or shall I?
Comment 4 Andras Becsi 2013-01-08 04:24:05 PST
(In reply to comment #3)
> Andras, this looks like something worth for backporting into stable. Do you have time to do it after landing or shall I?

I can do it.
Comment 5 WebKit Review Bot 2013-01-08 05:30:02 PST
Comment on attachment 181680 [details]
[Qt] Fix libxml2 config test

Clearing flags on attachment: 181680

Committed r139052: <http://trac.webkit.org/changeset/139052>
Comment 6 WebKit Review Bot 2013-01-08 05:30:06 PST
All reviewed patches have been landed.  Closing bug.