Bug 106315

Summary: [Chromium] Don't confine page popups to root view on Mac
Product: WebKit Reporter: Keishi Hattori <keishi>
Component: FormsAssignee: Keishi Hattori <keishi>
Status: RESOLVED FIXED    
Severity: Normal CC: tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Keishi Hattori
Reported 2013-01-08 02:01:03 PST
After https://src.chromium.org/viewvc/chrome?view=rev&revision=175488 page popups on Mac won't be clipped to the web view so we need to change the code that positions the popup.
Attachments
Patch (2.88 KB, patch)
2013-01-08 02:23 PST, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Patch (8.06 KB, patch)
2013-01-08 03:59 PST, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keishi Hattori
Comment 1 2013-01-08 02:23:20 PST
Created attachment 181674 [details] Patch
Kent Tamura
Comment 2 2013-01-08 02:26:23 PST
Comment on attachment 181674 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181674&action=review > Source/WebKit/chromium/ChangeLog:9 > + Page popups on mac no longer get clipped to the web view so we can set > + confineToRootView to false. We can remove confineToRootView flag entirely, can't we?
Keishi Hattori
Comment 3 2013-01-08 03:59:51 PST
Created attachment 181681 [details] Patch
Keishi Hattori
Comment 4 2013-01-08 04:01:18 PST
(In reply to comment #2) > (From update of attachment 181674 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=181674&action=review > > > Source/WebKit/chromium/ChangeLog:9 > > + Page popups on mac no longer get clipped to the web view so we can set > > + confineToRootView to false. > > We can remove confineToRootView flag entirely, can't we? Yes. Removed in this new patch.
Kent Tamura
Comment 5 2013-01-08 04:29:26 PST
Comment on attachment 181681 [details] Patch ok
WebKit Review Bot
Comment 6 2013-01-08 06:13:32 PST
Comment on attachment 181681 [details] Patch Clearing flags on attachment: 181681 Committed r139055: <http://trac.webkit.org/changeset/139055>
WebKit Review Bot
Comment 7 2013-01-08 06:13:36 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.