Summary: | [Shadow DOM] Distribution related code on ElementShadow should be minimized. | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hajime Morrita <morrita> | ||||||||||||
Component: | DOM | Assignee: | Hajime Morrita <morrita> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | cmarcelo, dglazkov, gtk-ews, ojan.autocc, philn, webcomponents-bugzilla, webkit.review.bot, xan.lopez | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Bug Depends on: | |||||||||||||||
Bug Blocks: | 103339 | ||||||||||||||
Attachments: |
|
Description
Hajime Morrita
2013-01-07 20:42:27 PST
Created attachment 181862 [details]
Patch
Comment on attachment 181862 [details] Patch Attachment 181862 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15771384 Comment on attachment 181862 [details] Patch Attachment 181862 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/15761402 Created attachment 181872 [details]
Patch
Comment on attachment 181872 [details] Patch Attachment 181872 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15762418 Comment on attachment 181872 [details] Patch Attachment 181872 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/15766361 Comment on attachment 181872 [details] Patch Attachment 181872 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/15757445 Created attachment 181882 [details]
Patch
Comment on attachment 181882 [details] Patch Attachment 181882 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15762444 New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html Comment on attachment 181882 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181882&action=review > Source/WebCore/dom/ElementShadow.h:69 > + void invalidateDistribution() { m_distributor.invalidateDistribution(host()); } > + void ensureDistribution() { m_distributor.ensureDistribution(host()); } > + void didAffectSelector(AffectedSelectorMask mask) { m_distributor.didAffectSelector(host(), mask); } > + void willAffectSelector() { m_distributor.willAffectSelector(host()); } I wonder if these plumb-throughs could be just eliminated? Comment on attachment 181882 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181882&action=review Thanks for reviewing! I believe cr-linux redness came fron the tree itself but I'll check it before landing. >> Source/WebCore/dom/ElementShadow.h:69 >> + void willAffectSelector() { m_distributor.willAffectSelector(host()); } > > I wonder if these plumb-throughs could be just eliminated? I first tried that but the code then had strange duplication: shadow->distributor().invalidateDistribution(shadow->host()); So I gave it up. Created attachment 182023 [details]
Patch for landing
Comment on attachment 182023 [details] Patch for landing Rejecting attachment 182023 [details] from commit-queue. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: file Source/WebCore/testing/Internals.cpp patching file Source/WebKit/win/WebKit.vcproj/WebKit.def.in Hunk #1 FAILED at 181. Hunk #2 FAILED at 570. Hunk #3 FAILED at 959. Hunk #4 FAILED at 1348. 4 out of 4 hunks FAILED -- saving rejects to file Source/WebKit/win/WebKit.vcproj/WebKit.def.in.rej patching file Source/autotools/symbols.filter patching file ChangeLog Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/15758740 Created attachment 182035 [details]
Patch for landing
Comment on attachment 182035 [details] Patch for landing Clearing flags on attachment: 182035 Committed r139269: <http://trac.webkit.org/changeset/139269> All reviewed patches have been landed. Closing bug. |