Bug 106286

Summary: [WK2] NetworkProcess should have a Keychain shim
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebKit2Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, beidson, mitz, sam
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch
none
with feedback addressed sam: review+

Alexey Proskuryakov
Reported 2013-01-07 18:25:36 PST
Just like WebProcess, NetworkProcess should forward Keychain calls to UI process. <rdar://problem/12882760>
Attachments
proposed patch (42.75 KB, patch)
2013-01-07 18:31 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
with feedback addressed (42.05 KB, patch)
2013-01-08 09:47 PST, Alexey Proskuryakov 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2013-01-07 18:31:58 PST
Created attachment 181619 [details] proposed patch
Sam Weinig
Comment 2 2013-01-07 19:48:09 PST
Comment on attachment 181619 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=181619&action=review > Source/WebKit2/NetworkProcess/NetworkProcess.h:83 > virtual void initializeProcessName(const ChildProcessInitializationParameters&) OVERRIDE; > virtual void initializeSandbox(const ChildProcessInitializationParameters&) OVERRIDE; > virtual bool shouldTerminate() OVERRIDE; > + virtual void initializeConnection(CoreIPC::Connection*) OVERRIDE; Please group this with the other initialize functions above. > Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm:117 > - processShimPathNSString = [[processAppExecutablePath stringByDeletingLastPathComponent] stringByAppendingPathComponent:@"PluginProcessShim.dylib"]; > + processShimPathNSString = [[processAppExecutablePath stringByDeletingLastPathComponent] stringByAppendingPathComponent:@"SecItemShim.dylib"]; This seems wrong. Why are you changing the plugin process shim?
Alexey Proskuryakov
Comment 3 2013-01-08 09:47:45 PST
Created attachment 181703 [details] with feedback addressed
Alexey Proskuryakov
Comment 4 2013-01-08 09:53:30 PST
Committed <http://trac.webkit.org/changeset/139066>.
Note You need to log in before you can comment on or make changes to this bug.