Bug 106286

Summary:

[WK2] NetworkProcess should have a Keychain shim

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

WebKit2

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, beidson, mitz, sam

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch	none
with feedback addressed	sam: review+

Description Alexey Proskuryakov 2013-01-07 18:25:36 PST

Just like WebProcess, NetworkProcess should forward Keychain calls to UI process.

<rdar://problem/12882760>

Comment 1 Alexey Proskuryakov 2013-01-07 18:31:58 PST

Created attachment 181619 [details]
proposed patch

Comment 2 Sam Weinig 2013-01-07 19:48:09 PST

Comment on attachment 181619 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181619&action=review

> Source/WebKit2/NetworkProcess/NetworkProcess.h:83
>      virtual void initializeProcessName(const ChildProcessInitializationParameters&) OVERRIDE;
>      virtual void initializeSandbox(const ChildProcessInitializationParameters&) OVERRIDE;
>      virtual bool shouldTerminate() OVERRIDE;
> +    virtual void initializeConnection(CoreIPC::Connection*) OVERRIDE;

Please group this with the other initialize functions above.

> Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm:117
> -        processShimPathNSString = [[processAppExecutablePath stringByDeletingLastPathComponent] stringByAppendingPathComponent:@"PluginProcessShim.dylib"];
> +        processShimPathNSString = [[processAppExecutablePath stringByDeletingLastPathComponent] stringByAppendingPathComponent:@"SecItemShim.dylib"];

This seems wrong. Why are you changing the plugin process shim?

Comment 3 Alexey Proskuryakov 2013-01-08 09:47:45 PST

Created attachment 181703 [details]
with feedback addressed

Comment 4 Alexey Proskuryakov 2013-01-08 09:53:30 PST

Committed <http://trac.webkit.org/changeset/139066>.