Bug 106272

Summary: [chromium] Don't use double tap zoom if minimum and maximum page scale is the same
Product: WebKit Reporter: yusufo
Component: New BugsAssignee: yusufo
Status: RESOLVED FIXED    
Severity: Normal CC: aelias, jamesr, webkit.review.bot, yusufo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description yusufo 2013-01-07 15:57:32 PST
Don't use double tap zoom if minimum and maximum page scale is the same
Comment 1 yusufo 2013-01-07 15:58:04 PST
Created attachment 181588 [details]
Patch
Comment 2 James Robinson 2013-01-07 16:07:59 PST
Comment on attachment 181588 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181588&action=review

> Source/WebKit/chromium/ChangeLog:10
> +We should only try to computed relevant scale and scrollOffset and start the animation
> +if the page is zoomable. This now creates an undesired animation for mobile pages which
> +are not zoomable.

nit: this should be 8-space indented
Comment 3 yusufo 2013-01-07 16:22:28 PST
Created attachment 181594 [details]
Patch
Comment 4 WebKit Review Bot 2013-01-07 17:10:24 PST
Comment on attachment 181594 [details]
Patch

Clearing flags on attachment: 181594

Committed r139017: <http://trac.webkit.org/changeset/139017>
Comment 5 WebKit Review Bot 2013-01-07 17:10:27 PST
All reviewed patches have been landed.  Closing bug.