Bug 106264

Summary: Remove Windows files from WebKit2
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, kenneth, noam, ossy, rafael.lobo, sam, tmpsantos
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review+

Anders Carlsson
Reported 2013-01-07 15:29:00 PST
Remove Windows files from WebKit2
Attachments
Patch (436.10 KB, patch)
2013-01-07 15:30 PST, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-01-07 15:30:42 PST
Created attachment 181576 [details] Patch
Sam Weinig
Comment 2 2013-01-07 15:31:18 PST
Comment on attachment 181576 [details] Patch r is me!
Anders Carlsson
Comment 3 2013-01-07 15:37:24 PST
Committed r139003: <http://trac.webkit.org/changeset/139003>
Csaba Osztrogonác
Comment 4 2013-01-08 01:21:05 PST
(In reply to comment #3) > Committed r139003: <http://trac.webkit.org/changeset/139003> and Qt-Windows buildfix landed in https://trac.webkit.org/changeset/139041 ...
Simon Hausmann
Comment 5 2013-01-08 02:10:56 PST
I would have been nice to see an announcement or discussion about this! In the Qt port we are using and shipping Qt 5.0 with WebKit2 on Windows.
Sam Weinig
Comment 6 2013-01-08 10:54:45 PST
(In reply to comment #5) > I would have been nice to see an announcement or discussion about this! > > In the Qt port we are using and shipping Qt 5.0 with WebKit2 on Windows. (In reply to comment #5) > I would have been nice to see an announcement or discussion about this! > > In the Qt port we are using and shipping Qt 5.0 with WebKit2 on Windows. We don't plan on support WebKit2 for Windows in general, so if you have Windows specific functionality, you should probably make it Qt specific.
Simon Hausmann
Comment 7 2013-01-08 13:25:31 PST
(In reply to comment #6) > (In reply to comment #5) > > I would have been nice to see an announcement or discussion about this! > > > > In the Qt port we are using and shipping Qt 5.0 with WebKit2 on Windows. > (In reply to comment #5) > > I would have been nice to see an announcement or discussion about this! > > > > In the Qt port we are using and shipping Qt 5.0 with WebKit2 on Windows. > > We don't plan on support WebKit2 for Windows in general, so if you have Windows specific functionality, you should probably make it Qt specific. Would you be okay if we re-added the Windows specific files we need to keep the Qt port of WebKit2 running on Windows and maintain them?
Csaba Osztrogonác
Comment 8 2013-01-08 22:43:23 PST
(In reply to comment #7) > Would you be okay if we re-added the Windows specific files we need to keep the Qt port of WebKit2 running on Windows and maintain them? I exactly did it, simple readded these files - https://trac.webkit.org/changeset/139041.
Simon Hausmann
Comment 9 2013-01-08 22:56:56 PST
Thank you, Ossy!
Note You need to log in before you can comment on or make changes to this bug.