Summary: | garden-o-matic shouldn’t hard-code a list of buildbots for build.webkit.org | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | NEW --- | ||||||||
Severity: | Normal | CC: | abarth, dbates, dglazkov, dpranke, eric, simon.fraser, timloh, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 107057 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Ryosuke Niwa
2013-01-07 15:00:33 PST
For the chromium bots, it will need to query build.chromium.org and have a mapping from bot name to whether it's debug/release and what it's "version" is (e.g. lion, snowleopard, etc). We already query build.chromium.org and build.webkit.org for the list of bots so that we can show non-layout test errors in garden-o-matic. Created attachment 183355 [details]
Patch
Attachment 183355 [details] did not pass style-queue:
Traceback (most recent call last):
File "/mnt/git/webkit-style-queue/Tools/Scripts/webkit-patch", line 44, in <module>
from webkitpy.tool.main import WebKitPatch
File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/tool/main.py", line 37, in <module>
from webkitpy.common.host import Host
File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/common/host.py", line 38, in <module>
from webkitpy.common.net.buildbot.chromiumbuildbot import ChromiumBuildBot
File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py", line 32, in <module>
from webkitpy.layout_tests.port.builders import builder_path_from_name
File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/layout_tests/port/__init__.py", line 31, in <module>
import builders # Why is this in port?
File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/layout_tests/port/builders.py", line 117, in <module>
_exact_matches = _get_build_chromium_org_builders()
File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/layout_tests/port/builders.py", line 112, in _get_build_chromium_org_builders
raise Exception("Unknown version '%s' for builder '%s'" % (version, name))
Exception: Unknown version 'Android' for builder 'WebKit Android (GalaxyNexus)'
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 183355 [details]
Patch
We need some sort of sanity check tests for this.
Comment on attachment 183355 [details]
Patch
it killed EWS bots, they can't process it.
Created attachment 183690 [details]
Patch
Comment on attachment 183690 [details]
Patch
Should we include the current copy of the json in a unittest to verify that all teh parser rules work?
I mean, this looks OK. I suspect we're going to need to edit this code as the json changes. I'm not sure what keeps us from getting confused as someone adds non-standardly named builders? We have unittests for the master.cfg file for webkit.org. I don't know what (if any) unittests exist for the chromium one.
|