Bug 106254

Summary: Dashboard Cleanup: Remove g_hasDoneInitialPageGeneration
Product: WebKit Reporter: Julie Parent <jparent>
Component: Tools / TestsAssignee: Julie Parent <jparent>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, ojan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Julie Parent
Reported 2013-01-07 14:27:12 PST
Dashboard Cleanup: Remove g_hasDoneInitialPageGeneration
Attachments
Patch (3.31 KB, patch)
2013-01-07 14:32 PST, Julie Parent 		no flags
DetailsFormatted DiffDiff
Patch (3.35 KB, patch)
2013-01-08 08:48 PST, Julie Parent 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Julie Parent
Comment 1 2013-01-07 14:32:38 PST
Created attachment 181568 [details] Patch
Adam Barth
Comment 2 2013-01-07 16:47:13 PST
Comment on attachment 181568 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=181568&action=review > Tools/ChangeLog:5 > + Dashboard Cleanup: Remove g_hasDoneInitialPageGeneration > + https://bugs.webkit.org/show_bug.cgi?id=106254 > + Typically it's a good idea to leave the "Reviewed by NOBODY (OOPS!)" line in the ChangeLog so that the bots can replace it with the name of the person who actually reviewed this change.
Adam Barth
Comment 3 2013-01-07 16:47:31 PST
I wanted to r=me this patch, but I didn't quite feel like I understood the code well enough.
Julie Parent
Comment 4 2013-01-08 08:48:54 PST
Created attachment 181701 [details] Patch
Julie Parent
Comment 5 2013-01-08 08:50:54 PST
Fixed the ChangeLog, I didn't mean to remove the Reviewed by line. Can someone else more familiar with the code take a look at this? It is actually a pretty simple change, I outlined the logic behind it in the ChangeLog (the fact that it doesn't look obvious is exactly why I'm doing this cleanup ... there is a lot of logic flow in the dashboards controlled by completely unintuitive global variables!)
WebKit Review Bot
Comment 6 2013-01-08 11:01:55 PST
Comment on attachment 181701 [details] Patch Clearing flags on attachment: 181701 Committed r139082: <http://trac.webkit.org/changeset/139082>
WebKit Review Bot
Comment 7 2013-01-08 11:02:00 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.