| Summary: | Dashboard Cleanup: Add isLoadingComplete to the loader.Loader object. | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Julie Parent <jparent> | ||||||||||||
| Component: | Tools / Tests | Assignee: | Julie Parent <jparent> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | abarth, dpranke, ojan, tony, webkit.review.bot | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Julie Parent
2013-01-07 13:30:39 PST
Created attachment 181555 [details]
Patch
Created attachment 182193 [details]
Patch
Updated patch to merge in all my other recent changes. Comment on attachment 182193 [details]
Patch
looks fine, except that I don't understand the fixme fully. You're saying that loader.Loader() should take a callback, or load() should take a callback?
Either way would work (or Loader could dispatch an event when it is done loading, and we could react to that instead). The main point is that the Loader shouldn't know anything about this random global function defined elsewhere, it should be self-contained. Updated the fixme. Created attachment 182373 [details]
Patch for landing
Created attachment 182375 [details]
Patch for landing
Created attachment 182377 [details]
Patch for landing
Comment on attachment 182375 [details]
Patch for landing
Sorry for the spam, there was a bug in land-safely and Ojan was trying to repro.
Comment on attachment 182375 [details] Patch for landing Clearing flags on attachment: 182375 Committed r139471: <http://trac.webkit.org/changeset/139471> All reviewed patches have been landed. Closing bug. |