Bug 106242

Summary: [EFL] Enable scaled cursors
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, gyuyoung.kim, kenneth, laszlo.gombos, lucas.de.marchi, rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 99493    
Bug Blocks: 106240    
Attachments:
Description Flags
Patch
buildbot: commit-queue-
Patch
none
Patch
gyuyoung.kim: review+
Patch for landing none

Description Chris Dumez 2013-01-07 11:56:58 PST 
Cursor image scaling should be enabled via ENABLE_MOUSE_CURSOR_SCALE flag. Some work is also needed in CursorEfl.cpp and for the WK2 Cursor serialization.
Comment 1 Chris Dumez 2013-01-07 12:08:24 PST 
Created attachment 181543 [details]
Patch
Comment 2 Build Bot 2013-01-07 13:04:32 PST 
Comment on attachment 181543 [details]
Patch

Attachment 181543 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15739860
Comment 3 Chris Dumez 2013-01-07 13:21:48 PST 
Created attachment 181548 [details]
Patch

Export additional symbol to attempt to fix mac build.
Comment 4 Chris Dumez 2013-01-09 07:31:55 PST 
I am splitting the WK2-part to Bug 106455 to get review from a WK2 Owner.
Comment 5 Chris Dumez 2013-01-09 09:00:00 PST 
Created attachment 181930 [details]
Patch

I simplified the patch. We don't need the change to WK2 IPC after all.
Comment 6 Chris Dumez 2013-01-19 10:55:11 PST 
Could someone please take a look?
Comment 7 Gyuyoung Kim 2013-04-30 04:02:45 PDT 
Comment on attachment 181930 [details]
Patch

LGTM, BTW, can this feature run on EFL WK1 as well ?
Comment 8 Chris Dumez 2013-04-30 05:14:15 PDT 
Created attachment 200100 [details]
Patch for landing
Comment 9 Chris Dumez 2013-04-30 05:34:19 PDT 
(In reply to comment #7)
> (From update of attachment 181930 [details])
> LGTM, BTW, can this feature run on EFL WK1 as well ?

The parsing part and therefore the test yes.
Comment 10 WebKit Commit Bot 2013-04-30 06:16:21 PDT 
Comment on attachment 200100 [details]
Patch for landing

Clearing flags on attachment: 200100

Committed r149362: <http://trac.webkit.org/changeset/149362>
Comment 11 WebKit Commit Bot 2013-04-30 06:16:24 PDT 
All reviewed patches have been landed.  Closing bug.