Summary: | media/video-controls-captions.html fails after fixing https://bugs.webkit.org/show_bug.cgi?id=105536 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||
Component: | Media | Assignee: | Victor Carbune <vcarbune> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric.carlson, feature-media-reviews, ojan.autocc, silviapf, silviapfeiffer1, vcarbune, webkit-bug-importer, webkit.review.bot | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Antoine Quint
2013-01-07 10:15:53 PST
I applied your patch from bug 105536 and the test is failing because with the patch applied the toggling the captions button has no effect anymore (e.g. a user can't disable track rendering). I didn't look yet in the code for the cause. (In reply to comment #2) > I applied your patch from bug 105536 and the test is failing because with the > patch applied the toggling the captions button has no effect anymore (e.g. a user > can't disable track rendering). I didn't look yet in the code for the cause. It fails because clicking the captions button in a port without a captions menu eventually ends up in HTMLMediaElement::markCaptionAndSubtitleTracksAsUnconfigured, which depends on the code removed from HTMLMediaElement::configureTextTrackGroup by bug 105536 to choose the most appropriate default track. OK, I will work on introducing the caption menu for Chrome today. Created attachment 182151 [details]
Fix
*** Bug 106433 has been marked as a duplicate of this bug. *** Comment on attachment 182151 [details] Fix Clearing flags on attachment: 182151 Committed r139326: <http://trac.webkit.org/changeset/139326> All reviewed patches have been landed. Closing bug. |