Bug 106197

Summary: [GTK] Enable Performance Timeline, Resource Timing, Navigation Timing features
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates, mrobinson, philn, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Zan Dobersek
Reported 2013-01-06 12:36:03 PST
[GTK] Enable Performance Timeline, Resource Timing, Navigation Timing features
Attachments
Patch (13.66 KB, patch)
2013-01-06 12:45 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2013-01-06 12:45:51 PST
Created attachment 181464 [details] Patch
Martin Robinson
Comment 2 2013-01-07 09:00:52 PST
Comment on attachment 181464 [details] Patch So is this enabling them for both a release and development build?
Zan Dobersek
Comment 3 2013-01-07 11:46:15 PST
(In reply to comment #2) > (From update of attachment 181464 [details]) > So is this enabling them for both a release and development build? Only for development builds. All three defines default to 0 in GNUmakefile.features.am.in. The build-webkit script overrides them with 1 when used. The build error seems valid, I'll check on that and report back.
Zan Dobersek
Comment 4 2013-01-08 01:46:07 PST
(In reply to comment #3) > The build error seems valid, I'll check on that and report back. The build error doesn't occur on clean build, so that's what's required when this patch lands.
Zan Dobersek
Comment 5 2013-01-15 11:48:47 PST
Comment on attachment 181464 [details] Patch Clearing flags on attachment: 181464 Committed r139768: <http://trac.webkit.org/changeset/139768>
Zan Dobersek
Comment 6 2013-01-15 11:48:52 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.