Bug 106194

Summary:

[GTK] Build failures when building with python 3.3

Product:

WebKit

Reporter:

Zan Dobersek <zan>

Component:

WebKitGTK

Assignee:

Zan Dobersek <zan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dpranke, eric, ojan, pfeldman, prybin, yurys

Priority:

Keywords:

Gtk

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Zan Dobersek

Reported 2013-01-06 08:59:19 PST

The build fails in Source/WebCore/inspector/generate-inspector-protocol-version, as reported by onny on IRC: (07:19:06 PM) onny_: [13:30:15] /usr/bin/python ../Source/WebCore/inspector/generate-inspector-protocol-version -o ./DerivedSources/WebCore/InspectorProtocolVersion.h ../Source/WebCore/inspector/Inspector.json The override-feature-defines script also fails with python3, that's covered by bug #105742. Apart from that, I was able to build fine with python3.2, but the failure is reported when using python3.3.

Attachments
Patch (2.20 KB, patch) 2013-01-06 11:12 PST, Zan Dobersek	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Zan Dobersek

Comment 1 2013-01-06 11:12:20 PST

Created attachment 181462 [details] Patch

Build Bot

Comment 2 2013-01-06 12:43:17 PST

Comment on attachment 181462 [details] Patch Attachment 181462 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15741465 New failing tests: svg/as-image/img-relative-height.html

Zan Dobersek

Comment 3 2013-01-06 12:50:34 PST

(In reply to comment #2) > (From update of attachment 181462 [details]) > Attachment 181462 [details] did not pass mac-ews (mac): > Output: http://queues.webkit.org/results/15741465 > > New failing tests: > svg/as-image/img-relative-height.html A flaky test. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=svg%2Fas-image%2Fimg-relative-height.html

Zan Dobersek

Comment 4 2013-01-06 12:53:43 PST

CC-ing author and reviewer of the last few meaningful changes to Source/WebCore/inspector/generate-inspector-protocol-version.

Zan Dobersek

Comment 5 2013-01-08 09:30:30 PST

CC-ing some Python gurus to also have a look.

Zan Dobersek

Comment 6 2013-01-08 10:55:48 PST

Comment on attachment 181462 [details] Patch Clearing flags on attachment: 181462 Committed r139081: <http://trac.webkit.org/changeset/139081>

Zan Dobersek

Comment 7 2013-01-08 10:55:53 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.