Bug 106192

Summary: Merge child process main functions as much as possible
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch andersca: review+

Description Sam Weinig 2013-01-05 20:10:59 PST
Merge child process main functions as much as possible
Comment 1 Sam Weinig 2013-01-05 20:34:13 PST
Created attachment 181451 [details]
Comment 2 WebKit Review Bot 2013-01-05 20:36:03 PST
Attachment 181451 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/Shared/mac/ChildProcessMain.h:37:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WebKit2/Shared/mac/ChildProcessMain.h:56:  The parameter name "identifier" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 9 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2013-01-07 13:27:16 PST
Committed r138981: <http://trac.webkit.org/changeset/138981>