WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
106192
Merge child process main functions as much as possible
https://bugs.webkit.org/show_bug.cgi?id=106192
Summary
Merge child process main functions as much as possible
Sam Weinig
Reported
2013-01-05 20:10:59 PST
Merge child process main functions as much as possible
Attachments
Patch
(41.50 KB, patch)
2013-01-05 20:34 PST
,
Sam Weinig
andersca
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2013-01-05 20:34:13 PST
Created
attachment 181451
[details]
Patch
WebKit Review Bot
Comment 2
2013-01-05 20:36:03 PST
Attachment 181451
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/Shared/mac/ChildProcessMain.h:37: Extra space before ( in function call [whitespace/parens] [4] Source/WebKit2/Shared/mac/ChildProcessMain.h:56: The parameter name "identifier" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 3
2013-01-07 13:27:16 PST
Committed
r138981
: <
http://trac.webkit.org/changeset/138981
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug