Bug 106192 - Merge child process main functions as much as possible
Summary: Merge child process main functions as much as possible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-05 20:10 PST by Sam Weinig
Modified: 2013-01-07 13:27 PST (History)
1 user (show)

See Also:

Attachments
Patch (41.50 KB, patch)
2013-01-05 20:34 PST, Sam Weinig 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2013-01-05 20:10:59 PST 
Merge child process main functions as much as possible
Comment 1 Sam Weinig 2013-01-05 20:34:13 PST 
Created attachment 181451 [details]
Patch
Comment 2 WebKit Review Bot 2013-01-05 20:36:03 PST 
Attachment 181451 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/Shared/mac/ChildProcessMain.h:37:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WebKit2/Shared/mac/ChildProcessMain.h:56:  The parameter name "identifier" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2013-01-07 13:27:16 PST 
Committed r138981: <http://trac.webkit.org/changeset/138981>