Bug 106166

Summary: Make WKViews work when layer-backed
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, andersca, cgarcia, cmarcelo, gustavo, gyuyoung.kim, menard, mrobinson, philn, rakuco, sam, simon.fraser, webkit-bug-importer, webkit-ews, webkit.review.bot, xan.lopez
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch (fixing other ports) simon.fraser: review+

Simon Fraser (smfr)
Reported 2013-01-04 20:37:22 PST
Make WKViews work when layer-backed
Attachments
Patch (6.13 KB, patch)
2013-01-04 20:41 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (fixing other ports) (10.18 KB, patch)
2013-01-07 11:22 PST, Simon Fraser (smfr) 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2013-01-04 20:41:18 PST
Created attachment 181425 [details] Patch
Simon Fraser (smfr)
Comment 2 2013-01-04 20:41:49 PST
<rdar://problem/12824569>
Early Warning System Bot
Comment 3 2013-01-04 20:48:02 PST
Comment on attachment 181425 [details] Patch Attachment 181425 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15710561
EFL EWS Bot
Comment 4 2013-01-04 20:56:18 PST
Comment on attachment 181425 [details] Patch Attachment 181425 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15703569
Simon Fraser (smfr)
Comment 5 2013-01-07 11:22:51 PST
Created attachment 181537 [details] Patch (fixing other ports)
WebKit Review Bot
Comment 6 2013-01-07 11:25:12 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Darin Adler
Comment 7 2013-01-07 11:25:48 PST
Comment on attachment 181537 [details] Patch (fixing other ports) View in context: https://bugs.webkit.org/attachment.cgi?id=181537&action=review > Source/WebKit2/UIProcess/PageClient.h:93 > + // Return rue if scrollView() can copy bits in the view. > + virtual bool canScrollView() = 0; Typo: "rue". Name "can scroll view" doesn’t seem to be related to whether copying bits is OK. Can we come up with a better name? I think we’ve dealt with this elsewhere.
Simon Fraser (smfr)
Comment 8 2013-01-07 11:30:32 PST
(In reply to comment #7) > (From update of attachment 181537 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=181537&action=review > > > Source/WebKit2/UIProcess/PageClient.h:93 > > + // Return rue if scrollView() can copy bits in the view. > > + virtual bool canScrollView() = 0; > > Typo: "rue". > > Name "can scroll view" doesn’t seem to be related to whether copying bits is OK. Can we come up with a better name? I think we’ve dealt with this elsewhere. I was following the naming of scrollView(), which I think is also confusing (in more ways than one!).
Simon Fraser (smfr)
Comment 9 2013-01-07 11:58:28 PST
http://trac.webkit.org/changeset/138973
Note You need to log in before you can comment on or make changes to this bug.