Bug 106141

Summary: [BlackBerry] SelectionHandler::selectAtPoint should use last fat finger result when it is a link
Product: WebKit Reporter: Andy Chen <andchen>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, rwlbuis, tonikitoo, webkit.review.bot, yong.li.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Andy Chen 2013-01-04 15:38:32 PST
Use the last fat finger result instead of selecting text again. Otherwise, it would get similar fat finger result as the last one, only difference is the target type.
Comment 1 Andy Chen 2013-01-04 18:34:20 PST
Created attachment 181419 [details]
Patch
Comment 2 Rob Buis 2013-01-05 12:24:54 PST
Comment on attachment 181419 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=181419&action=review

LGTM.

> Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp:587
> +bool SelectionHandler::selectNodeIfFatFingersResultIsLink(FatFingersResult fatFingersResult)

A long name, but I can't suggest anything better/shorter.
Comment 3 WebKit Review Bot 2013-01-05 13:03:37 PST
Comment on attachment 181419 [details]
Patch

Clearing flags on attachment: 181419

Committed r138905: <http://trac.webkit.org/changeset/138905>
Comment 4 WebKit Review Bot 2013-01-05 13:03:40 PST
All reviewed patches have been landed.  Closing bug.