Bug 106085 – [Qt] Fix compilation with GStreamer 1.0

• Component: WebKit Qt
• Status: RESOLVED DUPLICATE

[Sebastian Dröge (slomo)]

See attached patch, the fullscreen window stuff is not ported yet but not disabled in this header.

[Sebastian Dröge (slomo)]

Created attachment 181290 [details]
patch to fix compilation with gstreamer 1.0

[Sebastian Dröge (slomo)]

Created attachment 181292 [details]
Fix compilation with gstreamer 1.0

[Sebastian Dröge (slomo)]

Created attachment 181438 [details]
Fix build with GStreamer 1.0

[Philippe Normand]

CCing some QtWebKit folks. Simon, Alexis, would you be ok with switching to gst 1.0?

[Simon Hausmann]

Comment on attachment 181438 [details]
Fix build with GStreamer 1.0

This change needs a changelog.

Are you switching all ports over to require 1.0? If yes, do you plan to remove the old code paths at the same time? (Less ifdefs)

[Philippe Normand]

(In reply to comment #5)
> (From update of attachment 181438 [details])
> This change needs a changelog.
> 
> Are you switching all ports over to require 1.0? If yes, do you plan to remove the old code paths at the same time? (Less ifdefs)

Yes we plan to remove 0.10 support when gst 1.2 will be released.

[Simon Hausmann]

(In reply to comment #6)
> (In reply to comment #5)
> > (From update of attachment 181438 [details] [details])
> > This change needs a changelog.
> > 
> > Are you switching all ports over to require 1.0? If yes, do you plan to remove the old code paths at the same time? (Less ifdefs)
> 
> Yes we plan to remove 0.10 support when gst 1.2 will be released.

Very good. Patch looks good to me, too, but needs a ChangeLog :)

[Sebastian Dröge (slomo)]

(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #5)
> > > (From update of attachment 181438 [details] [details] [details])
> > > This change needs a changelog.
> > > 
> > > Are you switching all ports over to require 1.0? If yes, do you plan to remove the old code paths at the same time? (Less ifdefs)
> > 
> > Yes we plan to remove 0.10 support when gst 1.2 will be released.
> 
> Very good. Patch looks good to me, too, but needs a ChangeLog :)

Will add one in a few minutes :)

Unconditionally switching to 1.0 is fine for you? Otherwise it would probably be possible to first check for 1.0, and if it isn't found fall back to 0.10... but my qmake skills are not good enough for that ;)

[Simon Hausmann]

(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #6)
> > > (In reply to comment #5)
> > > > (From update of attachment 181438 [details] [details] [details] [details])
> > > > This change needs a changelog.
> > > > 
> > > > Are you switching all ports over to require 1.0? If yes, do you plan to remove the old code paths at the same time? (Less ifdefs)
> > > 
> > > Yes we plan to remove 0.10 support when gst 1.2 will be released.
> > 
> > Very good. Patch looks good to me, too, but needs a ChangeLog :)
> 
> Will add one in a few minutes :)
> 
> Unconditionally switching to 1.0 is fine for you? Otherwise it would probably be possible to first check for 1.0, and if it isn't found fall back to 0.10... but my qmake skills are not good enough for that ;)

Well, if in the near future we're going to remove the 0.10 code path, then there's probably not much value in exercising your qmake skills like that ;)

[Csaba Osztrogonác]

I managed to make this patch work on Ubuntu 12.04 with installing
gstreamer1.0 libgstreamer-plugins-base1.0-dev packages from here:
https://launchpad.net/~gstreamer-developers/+archive/ppa

But installing gstreamer on our Debian Squeeze and Ubuntu 11.10 bots (and on
all developers' machine) isn't trivial thing ... It is simpler to make everyone
migrate to 12.04 and then do the switch. But it needs weeks.

[Csaba Osztrogonác]

Created attachment 182329 [details]
updated patch to ToT

[Simon Hausmann]

(In reply to comment #10)
> I managed to make this patch work on Ubuntu 12.04 with installing
> gstreamer1.0 libgstreamer-plugins-base1.0-dev packages from here:
> https://launchpad.net/~gstreamer-developers/+archive/ppa
> 
> But installing gstreamer on our Debian Squeeze and Ubuntu 11.10 bots (and on
> all developers' machine) isn't trivial thing ... It is simpler to make everyone
> migrate to 12.04 and then do the switch. But it needs weeks.

Ok, good points!

Ossy, what is a good time frame for you? How can we meet in the middle with the Gstreamer folks?

[Sebastian Dröge (slomo)]

Created attachment 182350 [details]
Fix QtWebKit compilation with GStreamer 1.0

What about this patch then? I'll put the qmake project file changes into a new bug for moving QtWebKit to GStreamer 1.0

Note that you can use the GStreamer 1.0 packages from Debian unstable on squeeze/wheezy just fine, and the same for Ubuntu.

[WebKit Review Bot]

Attachment 182350 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebKit/qt/ChangeLog:12:  Line contains tab character.  [whitespace/tab] [5]
Source/WebKit/qt/ChangeLog:13:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:10:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 4 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 182350 [details]
Fix QtWebKit compilation with GStreamer 1.0

Attachment 182350 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/15801494

[Early Warning System Bot]

Comment on attachment 182350 [details]
Fix QtWebKit compilation with GStreamer 1.0

Attachment 182350 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/15803464

[Csaba Osztrogonác]

(In reply to comment #13)
> Created an attachment (id=182350) [details]
> Fix QtWebKit compilation with GStreamer 1.0
> 
> What about this patch then? I'll put the qmake project file changes into a new bug for moving QtWebKit to GStreamer 1.0
> 
> Note that you can use the GStreamer 1.0 packages from Debian unstable on squeeze/wheezy just fine, and the same for Ubuntu.

Thanks for the idea, I'll check it soon.

[Csaba Osztrogonác]

Comment on attachment 182350 [details]
Fix QtWebKit compilation with GStreamer 1.0

Defining GST_API_VERSION_1 is necessary to fix the build.
(I can't find in gstreamer1.0 any definition of GST_API_VERSION_1.)

[Philippe Normand]

(In reply to comment #18)
> (From update of attachment 182350 [details])
> Defining GST_API_VERSION_1 is necessary to fix the build.
> (I can't find in gstreamer1.0 any definition of GST_API_VERSION_1.)

Yes it's a macro internal to webkit, we use it to differenciate 0.10 vs 1.0 gst code paths

[Csaba Osztrogonác]

We don't need 2 bug report for this bug. :)

*** This bug has been marked as a duplicate of bug 106669 ***

[Csaba Osztrogonác]

(In reply to comment #12)
> (In reply to comment #10)
> > I managed to make this patch work on Ubuntu 12.04 with installing
> > gstreamer1.0 libgstreamer-plugins-base1.0-dev packages from here:
> > https://launchpad.net/~gstreamer-developers/+archive/ppa
> > 
> > But installing gstreamer on our Debian Squeeze and Ubuntu 11.10 bots (and on
> > all developers' machine) isn't trivial thing ... It is simpler to make everyone
> > migrate to 12.04 and then do the switch. But it needs weeks.
> 
> Ok, good points!
> 
> Ossy, what is a good time frame for you? How can we meet in the middle with the Gstreamer folks?

Upgrade is coming soon, Ádám will send a heads-up mail 
this week about the schedule.

[Eric Seidel (no email)]

Comment on attachment 182350 [details]
Fix QtWebKit compilation with GStreamer 1.0

Cleared review? from attachment 182350 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).