Bug 106067

Summary: DFG should inline closure calls
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 106200, 106201, 106202    
Attachments:
Description Flags
work in progress
none
work in progress
none
the patch barraclough: review+

Filip Pizlo
Reported 2013-01-03 17:09:11 PST
Patch forthcoming.
Attachments
work in progress (23.05 KB, patch)
2013-01-03 17:10 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
work in progress (27.48 KB, patch)
2013-01-03 20:20 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (34.47 KB, patch)
2013-01-06 00:04 PST, Filip Pizlo 		barraclough: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2013-01-03 17:10:40 PST
Created attachment 181253 [details] work in progress
Filip Pizlo
Comment 2 2013-01-03 20:20:11 PST
Created attachment 181272 [details] work in progress
Filip Pizlo
Comment 3 2013-01-06 00:04:27 PST
Created attachment 181453 [details] the patch
WebKit Review Bot
Comment 4 2013-01-06 00:09:17 PST
Attachment 181453 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/bytecode/CodeBlock.h:939: The parameter name "codeOrigin" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gavin Barraclough
Comment 5 2013-01-06 17:17:11 PST
Comment on attachment 181453 [details] the patch Looks good, please fix the style issue, and you've added a couple of FIXMEs - this is fine, but so the work doesn't get lost it's good to file the bugs in bugzilla, & include references to them next to the fixme comment.
Filip Pizlo
Comment 6 2013-01-06 17:54:07 PST
(In reply to comment #5) > (From update of attachment 181453 [details]) > Looks good, please fix the style issue, and you've added a couple of FIXMEs - this is fine, but so the work doesn't get lost it's good to file the bugs in bugzilla, & include references to them next to the fixme comment. Thanks for the review! I will file bugs for the FIXMEs and fix style before landing.
Filip Pizlo
Comment 7 2013-01-06 18:26:45 PST
Landed in http://trac.webkit.org/changeset/138921
Note You need to log in before you can comment on or make changes to this bug.