| Summary: | DFG should inline closure calls | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||||
| Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 106200, 106201, 106202 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Filip Pizlo
2013-01-03 17:09:11 PST
Created attachment 181253 [details]
work in progress
Created attachment 181272 [details]
work in progress
Created attachment 181453 [details]
the patch
Attachment 181453 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/bytecode/CodeBlock.h:939: The parameter name "codeOrigin" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 1 in 18 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 181453 [details]
the patch
Looks good, please fix the style issue, and you've added a couple of FIXMEs - this is fine, but so the work doesn't get lost it's good to file the bugs in bugzilla, & include references to them next to the fixme comment.
(In reply to comment #5) > (From update of attachment 181453 [details]) > Looks good, please fix the style issue, and you've added a couple of FIXMEs - this is fine, but so the work doesn't get lost it's good to file the bugs in bugzilla, & include references to them next to the fixme comment. Thanks for the review! I will file bugs for the FIXMEs and fix style before landing. Landed in http://trac.webkit.org/changeset/138921 |