Bug 106055

Summary: testapi is failing with a block-related error in the Objc API
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mhahnenberg, webkit.review.bot
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch fpizlo: review+

Description Geoffrey Garen 2013-01-03 15:31:42 PST 
2013-01-03 15:11:05.211 testapi[88881:60b] TEST: "blockCallback(NSString *)": FAILED
Comment 1 Mark Hahnenberg 2013-01-04 11:08:27 PST 
Created attachment 181336 [details]
Patch
Comment 2 Mark Hahnenberg 2013-01-04 11:09:00 PST 
<rdar://problem/12954235>
Comment 3 Geoffrey Garen 2013-01-04 15:33:27 PST 
Comment on attachment 181336 [details]
Patch

You can save the old idiom's performance by just putting a "()" at the end.
Comment 4 Mark Hahnenberg 2013-01-04 16:44:38 PST 
Created attachment 181410 [details]
Patch
Comment 5 Geoffrey Garen 2013-01-04 16:49:47 PST 
Comment on attachment 181410 [details]
Patch

r=me
Comment 6 WebKit Review Bot 2013-01-07 10:32:41 PST 
Comment on attachment 181410 [details]
Patch

Clearing flags on attachment: 181410

Committed r138957: <http://trac.webkit.org/changeset/138957>
Comment 7 WebKit Review Bot 2013-01-07 10:32:44 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Mark Hahnenberg 2013-01-11 15:04:01 PST 
We have a similar bug in ObjCCallbackFunction.mm.
Comment 9 Mark Hahnenberg 2013-01-11 15:06:27 PST 
Created attachment 182427 [details]
Patch
Comment 10 Mark Hahnenberg 2013-01-11 15:11:05 PST 
Committed r139508: <http://trac.webkit.org/changeset/139508>