Summary: | [chromium] Remove the contents of WebVideoFrame class | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dana Jansens <danakj> | ||||||
Component: | New Bugs | Assignee: | Dana Jansens <danakj> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, dglazkov, eric.carlson, feature-media-reviews, fischman, fishd, jamesr, peter+ews, sheu, tkent+wkapi, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 107297 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Dana Jansens
2013-01-03 13:58:37 PST
Created attachment 181216 [details]
Patch
This depends on https://codereview.chromium.org/11754003/ Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Comment on attachment 181216 [details] Patch Attachment 181216 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15635947 Comment on attachment 181216 [details] Patch Attachment 181216 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/15638940 Comment on attachment 181216 [details]
Patch
R=me, but this won't compile until the chromium side lands.
Comment on attachment 181216 [details] Patch Rejecting attachment 181216 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/Source/Platform/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/15946462 Created attachment 183467 [details]
Patch for landing
Comment on attachment 183467 [details] Patch for landing Clearing flags on attachment: 183467 Committed r140158: <http://trac.webkit.org/changeset/140158> All reviewed patches have been landed. Closing bug. Something is android is using the WebVideoFrame members still. http://build.chromium.org/p/chromium.webkit/builders/Android%20Builder/builds/10613/steps/compile/logs/stdio#error1 webkit/media/android/webmediaplayer_android.cc: In member function 'virtual WebKit::WebVideoFrame* webkit_media::WebMediaPlayerAndroid::getCurrentFrame()': webkit/media/android/webmediaplayer_android.cc:393:35:error: 'scoped_ptr<WebKit::WebVideoFrame>::element_type' has no member named 'width' webkit/media/android/webmediaplayer_android.cc:393:58:error: 'scoped_ptr<WebKit::WebVideoFrame>::element_type' has no member named 'height' Re-opened since this is blocked by bug 107297 Comment on attachment 183467 [details] Patch for landing Clearing flags on attachment: 183467 Committed r144946: <http://trac.webkit.org/changeset/144946> All reviewed patches have been landed. Closing bug. |