Bug 106037

Summary: [chromium] Remove the contents of WebVideoFrame class
Product: WebKit Reporter: Dana Jansens <danakj>
Component: New BugsAssignee: Dana Jansens <danakj>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, eric.carlson, feature-media-reviews, fischman, fishd, jamesr, peter+ews, sheu, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 107297    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Dana Jansens 2013-01-03 13:58:37 PST
[chromium] Remove the contents of WebVideoFrame class
Comment 1 Dana Jansens 2013-01-03 13:59:38 PST
Created attachment 181216 [details]
Patch
Comment 2 Dana Jansens 2013-01-03 14:00:08 PST
This depends on https://codereview.chromium.org/11754003/
Comment 3 WebKit Review Bot 2013-01-03 14:02:01 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 WebKit Review Bot 2013-01-03 14:42:00 PST
Comment on attachment 181216 [details]
Patch

Attachment 181216 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/15635947
Comment 5 Peter Beverloo (cr-android ews) 2013-01-03 15:21:03 PST
Comment on attachment 181216 [details]
Patch

Attachment 181216 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/15638940
Comment 6 James Robinson 2013-01-03 16:05:35 PST
Comment on attachment 181216 [details]
Patch

R=me, but this won't compile until the chromium side lands.
Comment 7 WebKit Review Bot 2013-01-18 08:25:26 PST
Comment on attachment 181216 [details]
Patch

Rejecting attachment 181216 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

/mnt/git/webkit-commit-queue/Source/Platform/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/15946462
Comment 8 Dana Jansens 2013-01-18 08:31:53 PST
Created attachment 183467 [details]
Patch for landing
Comment 9 WebKit Review Bot 2013-01-18 09:02:29 PST
Comment on attachment 183467 [details]
Patch for landing

Clearing flags on attachment: 183467

Committed r140158: <http://trac.webkit.org/changeset/140158>
Comment 10 WebKit Review Bot 2013-01-18 09:02:34 PST
All reviewed patches have been landed.  Closing bug.
Comment 11 Dana Jansens 2013-01-18 09:45:34 PST
Something is android is using the WebVideoFrame members still.

http://build.chromium.org/p/chromium.webkit/builders/Android%20Builder/builds/10613/steps/compile/logs/stdio#error1

webkit/media/android/webmediaplayer_android.cc: In member function 'virtual WebKit::WebVideoFrame* webkit_media::WebMediaPlayerAndroid::getCurrentFrame()':
webkit/media/android/webmediaplayer_android.cc:393:35:error: 'scoped_ptr<WebKit::WebVideoFrame>::element_type' has no member named 'width'
webkit/media/android/webmediaplayer_android.cc:393:58:error: 'scoped_ptr<WebKit::WebVideoFrame>::element_type' has no member named 'height'
Comment 12 WebKit Review Bot 2013-01-18 09:46:55 PST
Re-opened since this is blocked by bug 107297
Comment 13 WebKit Review Bot 2013-03-06 10:48:23 PST
Comment on attachment 183467 [details]
Patch for landing

Clearing flags on attachment: 183467

Committed r144946: <http://trac.webkit.org/changeset/144946>
Comment 14 WebKit Review Bot 2013-03-06 10:48:28 PST
All reviewed patches have been landed.  Closing bug.