Bug 105995

Summary: Add FloatPoint::distance(Squared)ToPoint(const FloatPoint&) to match IntPoint
Product: WebKit Reporter: Steve Block <steveblock>
Component: New BugsAssignee: Steve Block <steveblock>
Status: ASSIGNED    
Severity: Normal CC: ahmad.saleem792, cmarcelo, commit-queue, dino, macpherson, menard, ojan.autocc, steveblock, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+, commit-queue: commit-queue-

Steve Block
Reported 2013-01-02 21:43:42 PST
Add FloatPoint::distance(Squared)ToPoint(const FloatPoint&) to match IntPoint
Attachments
Patch (9.37 KB, patch)
2013-01-02 21:45 PST, Steve Block 		darin: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Steve Block
Comment 1 2013-01-02 21:45:00 PST
Created attachment 181146 [details] Patch
Steve Block
Comment 2 2013-01-02 22:18:18 PST
Calculating the distance between two FloatPoints is a common operation, and IntPoint already has such a method, so it seems like a good idea to add these helpers to FloatPoint.
Darin Adler
Comment 3 2013-04-08 18:12:26 PDT
Comment on attachment 181146 [details] Patch OK
WebKit Commit Bot
Comment 4 2013-04-08 18:14:52 PDT
Comment on attachment 181146 [details] Patch Rejecting attachment 181146 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 181146, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: m/graphics/FloatPoint.h Hunk #1 FAILED at 149. Hunk #2 succeeded at 275 (offset 5 lines). 1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/platform/graphics/FloatPoint.h.rej patching file Source/WebCore/platform/graphics/gpu/LoopBlinnLocalTriangulator.cpp patching file Source/WebCore/platform/graphics/gpu/LoopBlinnMathUtils.cpp Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-commit-queue.appspot.com/results/17671010
Ahmad Saleem
Comment 5 2023-09-19 14:02:17 PDT
Do we need this now?
Note You need to log in before you can comment on or make changes to this bug.