| Summary: | Add FloatPoint::distance(Squared)ToPoint(const FloatPoint&) to match IntPoint | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Steve Block <steveblock> | ||||
| Component: | New Bugs | Assignee: | Steve Block <steveblock> | ||||
| Status: | ASSIGNED --- | ||||||
| Severity: | Normal | CC: | ahmad.saleem792, cmarcelo, commit-queue, dino, macpherson, menard, ojan.autocc, steveblock, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Steve Block
2013-01-02 21:43:42 PST
Created attachment 181146 [details]
Patch
Calculating the distance between two FloatPoints is a common operation, and IntPoint already has such a method, so it seems like a good idea to add these helpers to FloatPoint. Comment on attachment 181146 [details]
Patch
OK
Comment on attachment 181146 [details] Patch Rejecting attachment 181146 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 181146, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: m/graphics/FloatPoint.h Hunk #1 FAILED at 149. Hunk #2 succeeded at 275 (offset 5 lines). 1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/platform/graphics/FloatPoint.h.rej patching file Source/WebCore/platform/graphics/gpu/LoopBlinnLocalTriangulator.cpp patching file Source/WebCore/platform/graphics/gpu/LoopBlinnMathUtils.cpp Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-commit-queue.appspot.com/results/17671010 Do we need this now? |